| To: | "Li, Xin B" <xin.b.li@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] [RESEND] remove redundent call to hvm_do_resume |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | 2006年10月23日 11:51:08 +0100 |
| Delivery-date: | 2006年10月23日 03:51:38 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <B30DA1341B0CFA4893EF8A36B40B5C5D4BE013@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acb0CVpf06Hxya4XT6uW1ULXYRyKAQCGO58QABu3EN4= |
| Thread-topic: | [Xen-devel] [PATCH] [RESEND] remove redundent call to hvm_do_resume |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 22/10/06 22:38, "Li, Xin B" <xin.b.li@xxxxxxxxx> wrote: > Remove redundant call to hvm_do_resume. > In this patch IO event channels in qemu are used for IO done > notification only, so we can simplify the event checking handling in > hvm_do_resume. > Besides current intr notification from qemu is complete meanless, > because eithor it's done with an IO event, or acturally do thing since > the new xen consumed event channel, we will find a better way to > implement that functionality. I like avoiding hvm_do_resume() on every vm entry, so I took that part of the patch. The change to ioemu was odd -- there are other places that set send_event to 1 (the code that adds IRQs to the PIC IRR). We know that code is somewhat broken for SMP guests, but you *do* need to notify Xen when interrupts happen, right? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] Re: [XenPPC] [PATCH 0/10][TOOLS][XM-TEST] [v3] Update xm-test to support new architectures , Ewan Mellor |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH 10/10][TOOLS][XM-TEST] Fix Memory assumptions in the create tests , Ewan Mellor |
| Previous by Thread: | [Xen-devel] [PATCH] [RESEND] remove redundent call to hvm_do_resume , Li, Xin B |
| Next by Thread: | [Xen-devel] [PATCH] Move ACPI timer to HV , Yang, Xiaowei |
| Indexes: | [Date] [Thread] [Top] [All Lists] |