| To: | Keir Fraser <keir@xxxxxxxxxxxxx>, Xen Development Mailing List <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] [BLKTAP]: Kill duplicate fast_flush_area call |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | 2006年10月20日 14:31:05 +1000 |
| Delivery-date: | 2006年10月20日 08:33:42 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mutt/1.5.9i |
Hi Keir: [BLKTAP]: Kill duplicate fast_flush_area call The dispatch_rw_block_io may call fast_flush_area twice if create_lookup_pte_addr fails (there is a flush call at fail_flush already). The second call simply causes warnings to be printed on the console. This patch removes the duplicate call. Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- diff -r 4c40bed66ade linux-2.6-xen-sparse/drivers/xen/blktap/blktap.c --- a/linux-2.6-xen-sparse/drivers/xen/blktap/blktap.c Thu Oct 19 22:05:07 2006 +0100 +++ b/linux-2.6-xen-sparse/drivers/xen/blktap/blktap.c Fri Oct 20 14:24:58 2006 +1000 @@ -1195,8 +1195,6 @@ static void dispatch_rw_block_io(blkif_t uvaddr, &ptep); if (ret) { WPRINTK("Couldn't get a pte addr!\n"); - fast_flush_area(pending_req, pending_idx, usr_idx, - blkif->dev_num); goto fail_flush; } _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [TOOLS][RFC] xc_get_pfn_list() and getmemlist.start_pfn , Gerd Hoffmann |
|---|---|
| Next by Date: | [Xen-devel] [patch] Add support for barriers to blk{back, front} drivers. , kraxel |
| Previous by Thread: | [XenPPC] [PATCH 9/10][TOOLS][XM-TEST] Default to appending to "extra" in XenConfig , Tony Breeds |
| Next by Thread: | [Xen-devel] [patch] Add support for barriers to blk{back, front} drivers. , kraxel |
| Indexes: | [Date] [Thread] [Top] [All Lists] |