| To: | Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Fix argument check of xm reboot command (3) |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | 2006年7月10日 15:16:07 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | 2006年7月10日 07:16:37 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <74C6A116752B1Ckanno.masaki@xxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <74C6A116752B1Ckanno.masaki@xxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On 6 Jul 2006, at 17:08, Masaki Kanno wrote:
Wouldn't this be better checked in xend after it has converted domain name to domid, and an appropriate error string returned to the RPC caller? Putting the checking in xm seems a bit unnatural and means that other callers do not benefit.tested unlikely operations about the xm reboot/shutdown command. As a result, I found the following problems. Problem 1: Can reboot/shutdown Domain-0 by mistake. Problem 2: Can not reboot/shutdown domain of domain name '0'.
-- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] PATCH: support make -j in xen/ , Tristan Gingold |
|---|---|
| Next by Date: | Re: [Xen-devel] [RFC] [PATCH] HVM SMBIOS support 1/6 , Keir Fraser |
| Previous by Thread: | [Xen-devel] [PATCH] Fix argument check of xm reboot command (3) , Masaki Kanno |
| Next by Thread: | Re: [Xen-devel] [PATCH] Fix argument check of xm reboot command (3) , Masaki Kanno |
| Indexes: | [Date] [Thread] [Top] [All Lists] |