| To: | PUCCETTI Armand <armand.puccetti@xxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] e820.c : why char* ? (2nd try) |
| From: | Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx> |
| Date: | 2006年6月29日 11:06:37 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | 2006年6月29日 03:07:14 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <44A39F38.6010705@xxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <44A39F38.6010705@xxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Thu, 2006年06月29日 at 11:36 +0200, PUCCETTI Armand wrote: > In function > > sanitize_e820_map(struct e820entry * biosmap, char * pnr_map) > > of file e820.c, the last argument is treated as an integer, but when > compiling with gcc it belongs to [-128,127]. This is not a Xen specific issue. On native the value comes from the BIOS and is a single byte, hence the type. Xen uses the same function. I don't think it is possible for there to ever be more than 127 entries in an e820 map so other than potentially wasting a couple of entries in the tables I don't see a problem. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] Re: [PATCH 1/2] build: clean up kclean and distclean for kernel , Horms |
|---|---|
| Next by Date: | Re: [Xen-devel] [0/5] [NET]: Add TSO support , Keir Fraser |
| Previous by Thread: | [Xen-devel] e820.c : why char* ? (2nd try) , PUCCETTI Armand |
| Next by Thread: | [Xen-devel] build problems with unstable and linux Hi,2.6.16.20 , Hans-Christian Armingeon |
| Indexes: | [Date] [Thread] [Top] [All Lists] |