xen-devel
Re: [Xen-devel] RE: [Xen-users] Xen in a 32 way system
|
To: |
"Petersson, Mats" <Mats.Petersson@xxxxxxx> |
|
Subject: |
Re: [Xen-devel] RE: [Xen-users] Xen in a 32 way system |
|
From: |
Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
|
Date: |
Thu, 1 Jun 2006 19:08:36 +0100 |
|
Cc: |
xen-devel@xxxxxxxxxxxxxxxxxxx, "Puthiyaparambil, Aravindh" <aravindh.puthiyaparambil@xxxxxxxxxx>, Pablo Montesinos <pablomontesinos@xxxxxxxxx>, Ryan Harper <ryanh@xxxxxxxxxx>, Uros Trebec <uros.trebec@xxxxxxxxx>, xen-users@xxxxxxxxxxxxxxxxxxx |
|
Delivery-date: |
2006年6月01日 11:09:00 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<907625E08839C4409CE5768403633E0BA7FCD5@xxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<907625E08839C4409CE5768403633E0BA7FCD5@xxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On 1 Jun 2006, at 18:59, Petersson, Mats wrote:
Isn't it a bug that we don't check for -EINVAL in the line here:
for (i = 0; i < NR_CPUS; i++) {
rc = HYPERVISOR_vcpu_op(VCPUOP_is_up, i, NULL);
if (rc == -ENOENT)
break;
cpu_set(i, cpu_possible_map);
}
If NR_CPUS in Linux is bigger than 32, then rc = -EINVAL, not -ENOENT
when it returns from the vcpu_op, because the first check is to see if
vcpuid is >=32...
Checking if (rc < 0) would be better, I should think...
Yes, the current code is rather mad. I'll fix it.
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|