| To: | Markus Armbruster <armbru@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH 2/3] xenoprof fixes: active_domains races |
| From: | Chris Wright <chrisw@xxxxxxxxxxxx> |
| Date: | 2006年5月15日 11:53:10 -0700 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | 2006年5月15日 11:50:16 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <878xp32qqf.fsf@xxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <87hd3r2qst.fsf@xxxxxxxxxxxxxxxxx> <878xp32qqf.fsf@xxxxxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mutt/1.4.2.1i |
* Markus Armbruster (armbru@xxxxxxxxxx) wrote: > --- linux-2.6.16.13-xen.patched-1/drivers/oprofile/oprofile_files.c > 2006年05月15日 10:28:11.000000000 +0200 > +++ linux-2.6.16.13-xen.patched-2/drivers/oprofile/oprofile_files.c > 2006年05月15日 10:31:11.000000000 +0200 > @@ -128,6 +128,7 @@ static struct file_operations dump_fops > > unsigned int adomains = 0; > long active_domains[MAX_OPROF_DOMAINS]; > +static DECLARE_MUTEX(adom_sem); Sorry, didn't mention this earlier. Please use new mutex code here, smth like: s/DECLARE_MUTEX(adom_sec)/DEFINE_MUTEX(adomain_mutex)/ s/down(&adom_sem)/mutex_lock(&adomain_mutex)/ s/up(&adom_sem)/mutex_unlock(&admoain_mutex)/ thanks, -chris _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| Previous by Date: | [Xen-devel] Status re. intense graphics apps , g |
|---|---|
| Next by Date: | [Xen-devel] [PATCH] make HVM PIC emulation code SMP-safe , David Lively |
| Previous by Thread: | [Xen-devel] [PATCH] xenoprof fixes: active_domains races & cleanup , Markus Armbruster |
| Next by Thread: | Re: [Xen-devel] [PATCH 2/3] xenoprof fixes: active_domains races , Markus Armbruster |
| Indexes: | [Date] [Thread] [Top] [All Lists] |