| To: | Charles Duffy <cduffy@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] Changeset for reisermodule x86_64 compilation w/ -Wall |
| From: | Hollis Blanchard <hollisb@xxxxxxxxxx> |
| Date: | 2005年10月11日 10:34:03 -0500 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | 2005年10月11日 15:31:40 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <difs7e$jna1ドル@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <difs7e$jna1ドル@xxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Oct 11, 2005, at 3:14 AM, Charles Duffy wrote:
Compiling with -Wall is failing for me without application of this patch. I'm fairly sure someone else has independently proposed (pretty much) the same thing, but given that it didn't get applied, I'm reproposing it here.I don't understand this change. My close(2) man page says close takes an int, not a size_t. Charles, what is the exact -Wall error you're seeing? I can't seem to find "dal", but just a guess... is 'dal->dev' a 'void *'?# HG changeset patch # User cduffy@xxxxxxxxxxx # Node ID f3f8213f8d895c1b4e29647132aaea8633fb4825 # Parent e69413dca6844c87885121a7360fa7c2b11cdea9 fix 64-bit compilationdiff -r e69413dca684 -r f3f8213f8d89 tools/pygrub/src/fsys/reiser/reisermodule.c --- a/tools/pygrub/src/fsys/reiser/reisermodule.c Sat Oct 8 09:22:01 2005 +++ b/tools/pygrub/src/fsys/reiser/reisermodule.c Tue Oct 11 07:51:18 2005@@ -46,7 +46,7 @@ if (!dal) return; - close((int)dal->dev); + close((size_t)dal->dev); dal_free(dal); }
-- Hollis Blanchard IBM Linux Technology Center _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Re: [Xen-changelog] Added auxbin module, for handling auxillary binaries. , Ewan Mellor |
|---|---|
| Next by Date: | [Xen-devel] [PATCH] Fix xenstore compiliation problems , Jerone Young |
| Previous by Thread: | [Xen-devel] Changeset for reisermodule x86_64 compilation w/ -Wall , Charles Duffy |
| Next by Thread: | Re: [Xen-devel] Changeset for reisermodule x86_64 compilation w/ -Wall , Charles Duffy |
| Indexes: | [Date] [Thread] [Top] [All Lists] |