| To: | "King, Steven R" <steven.r.king@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] suggested event channel cleanups |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | 2005年10月11日 10:18:08 +0100 |
| Cc: | xen-devel List <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | 2005年10月11日 09:10:30 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <44BDAFB888F59F408FAE3CC35AB47041022BD367@orsmsx409 > |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <44BDAFB888F59F408FAE3CC35AB47041022BD367@orsmsx409 > |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On 10 Oct 2005, at 23:50, King, Steven R wrote:
Userspace may do this, but Xen doesn't. It makes sense to give those fields an unsigned type because Xen will never return a negative value. If higher-level interfaces outside Xen return a signed type, with -ve indicating error, there's no reason for Xen to do the same.This patch standardizes the type of "port" to "int" for event channelfunctions and structures. Internally, Xen is using "int" for ports, butuserland code has a mix of "int" and "u32". Type "int" is preferred inuserland, since some functions want to return a positive port value or anegative error code.
Isn't it quite normal to put the ''extern "C"' in the C++ program itself when including C header files?xenctrl.h: Added extern "C" to allow linking with C++ programs.
These were removed last week.; The correct interface for user-space programs is now ioctls via /dev/xen/evtchn. See examples of its use in console/daemon/io.c, for example.xenctrl.h: Added function prototype for event channel close. xenctrl.h: Added function prototype for interdomain event channel.
I've never offered up a patch before, so apologies if I'm abusing conventions.
There's nothing wrong with the format of the patch. :-) -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | AW: [Xen-devel] Re: [Xen-users] xen 3.0 boot problem , Stephan Böni |
|---|---|
| Next by Date: | RE: [Xen-devel] Re: [Xen-users] xen 3.0 boot problem , Ian Pratt |
| Previous by Thread: | [Xen-devel] suggested event channel cleanups , King, Steven R |
| Next by Thread: | [Xen-devel] A xenu kernel 2.6.11 with physical access to a PCI netcard. , Ariel E. Antigua |
| Indexes: | [Date] [Thread] [Top] [All Lists] |