| To: | <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | [Xen-devel] eliminate duplicate stack trace during bad page fault |
| From: | "Jan Beulich" <JBeulich@xxxxxxxxxx> |
| Date: | 2005年7月01日 17:07:44 +0200 |
| Delivery-date: | 2005年7月01日 15:05:59 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Other than native i386 code, the page fault handler in the guest for whatever
reason ran a stack_trace even though another one is run from die(). Since
screen space is limited, duplicating (perhaps long) stack traces seems quite
wasteful. Patch removing this duplication below/attached.
Jan
--- 2.6.11-xen/arch/xen/i386/mm/fault.c 2005年07月01日 09:14:09.081412024 -0700
+++ nxen-guest/arch/xen/i386/mm/fault.c 2005年07月01日 09:15:22.188298088 -0700
@@ -474,7 +474,6 @@ no_context:
machine_to_phys(page));
}
#endif
- show_trace(NULL, (unsigned long *)®s[1]);
die("Oops", regs, error_code);
bust_spinlocks(0);
do_exit(SIGKILL);
Attachment:
xenlinux-duplicate-trace.patch
Description: Binary data
_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] self-contained kernel tree , Keir Fraser |
|---|---|
| Next by Date: | [Xen-devel] correct exports , Jan Beulich |
| Previous by Thread: | [Xen-devel] self-contained kernel tree , Nils Toedtmann |
| Next by Thread: | [Xen-devel] correct exports , Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |