WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Xen

xen-devel

[Top] [All Lists]

Re: [Xen-devel] [PATCH] bug in default interface number computation

To: Guillaume Rousse <Guillaume.Rousse@xxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] bug in default interface number computation
From: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Date: 2006年12月18日 11:48:16 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: 2006年12月18日 03:48:08 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <4586679B.40007@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4586679B.40007@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Mon, Dec 18, 2006 at 11:04:11AM +0100, Guillaume Rousse wrote:
> As previously explained, the network-bridge script tries to
> automatically find the default network interface number with the
> following ligne:
> vifnum=${vifnum:-$(ip route list | awk '/^default / { print $NF }' | sed
> 's/^[^0-9]*//')}
>
> However, this fails on mandriva, because the parsed line is:
> default via 193.55.250.126 dev eth0 metric 10
>
> Attached patch fix this issue.
>
> BTW, that's the second time I'm sending it, I've had no answer sofar. If
> this is not the recommanded way to declare problems and send correction
> patches, just tell me.
Sorry about missing it the first time. Your patch looks fine to me -- if you
could just resend it with a Signed-off-by line, I'll put it in.
Ewan.
> diff -Naur xen-3.0.3_0-src/tools/examples/network-bridge 
> xen-3.0.3_0-src.fix_network_bridge/tools/examples/network-bridge
> --- xen-3.0.3_0-src/tools/examples/network-bridge 2006年10月15日 
> 14:22:03.000000000 +0200
> +++ xen-3.0.3_0-src.fix_network_bridge/tools/examples/network-bridge 
> 2006年12月18日 10:58:38.000000000 +0100
> @@ -59,7 +59,7 @@
> findCommand "$@"
> evalVariables "$@"
>
> -vifnum=${vifnum:-$(ip route list | awk '/^default / { print $NF }' | sed 
> 's/^[^0-9]*//')}
> ++vifnum=${vifnum:-$(ip route list 0.0.0.0/0 | sed 
> 's/.*dev[^0-9]\+\([0-9]\+\).*$/1円/')}
> vifnum=${vifnum:-0}
> bridge=${bridge:-xenbr${vifnum}}
> netdev=${netdev:-eth${vifnum}}
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date: Re: [Xen-devel] [PATCH] Configurable keyboard mapping for HVM , Ewan Mellor
Next by Date: Re: [Xen-devel] [PATCH] Configurable keyboard mapping for HVM , Guillaume Rousse
Previous by Thread: [Xen-devel] [PATCH] bug in default interface number computation , Guillaume Rousse
Next by Thread: Re: [Xen-devel] [PATCH] bug in default interface number computation , Guillaume Rousse
Indexes: [Date] [Thread] [Top] [All Lists]

Copyright ©, Citrix Systems Inc. All rights reserved. Legal and Privacy
Citrix This site is hosted by Citrix

AltStyle によって変換されたページ (->オリジナル) /