| To: | Jimi Xenidis <jimix@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] fix xenctl_cpumap translation to handle bitops accessed like arrays |
| From: | Keir Fraser <keir@xxxxxxxxxxxxx> |
| Date: | 2006年12月18日 09:26:07 +0000 |
| Delivery-date: | 2006年12月18日 01:25:41 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <E1Gw0CP-0006C6-Tb@xxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AccihovQyhVfZo55Edui4wANk04WTA== |
| Thread-topic: | [Xen-devel] [PATCH] fix xenctl_cpumap translation to handle bitops accessed like arrays |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 17/12/06 5:53 pm, "Jimi Xenidis" <jimix@xxxxxxxxxxxxxx> wrote: > On PowerPC (and other big endian and/or RISC architectures) bit > offsets in a bitmap are actually represented by a bit-offset from an > element in an array rather than a bit-offset from the base memory > pointer, see xen/include/asm-powerpc/bitops.h for a complete > explanation. > > This complicates the conversion of cpumask_t from/to xenctl_cpumap. > > The following patch allows an architecture to declare that bitops are > "by long" rather than "by bit" and use an alternate scheme for > encoding. If the array-element type matters on big-endian systems then the tools really need fixing: one libxc operation passes down a uint32_t unit; another a uint64_t. Perhaps we should fix so they pass down 8-bit units (as the type of xenctl_cpumap_t would suggest) and then we could have byte_to_long_bitmap and long_to_byte_bitmap in Xen (which might encourage us to pull proper endianness headers into Xen). -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [Patch] cleanup pciback_reset_device , Akio Takebe |
|---|---|
| Next by Date: | Re: [Xen-devel] Question about evtchn_callback reentry , Keir Fraser |
| Previous by Thread: | [Xen-devel] [PATCH] fix xenctl_cpumap translation to handle bitops accessed like arrays , Jimi Xenidis |
| Next by Thread: | Re: [Xen-devel] [PATCH] fix xenctl_cpumap translation to handle bitops accessed like arrays , Jimi Xenidis |
| Indexes: | [Date] [Thread] [Top] [All Lists] |