On Fri, Dec 01, 2006 at 01:25:42PM +0000, Steven Smith wrote:
> Applied.
>
> Thanks,
>
> Steven.
Looking at the patches applied for the PVFB code & config re-arrangement
I think that VNC password handling for fullyvirt HVM guests has been
broken
In changeset 
 changeset: 12679:000609d8c93fb24b2ca5dd7961dfae19ddb0022f
 user: Steven Smith <ssmith@xxxxxxxxxxxxx>
 date: Fri Dec 01 11:49:30 2006 +0000
 files: tools/python/xen/xend/XendDomainInfo.py 
tools/python/xen/xend/image.py tools/python/xen/xend/server/vfbif.py 
tools/python/xen/xm/create.py
 description:
 [PVFB][TOOLS] Change the configuration syntax for PVFB backends to more
 closely match that of other devices.
The following hunk against tools/python/xen/xm/create.py removes processing
of the 'vncpassword' config parameter from the guest config files for HVM
guests:
 @@ -678,20 +690,13 @@ def configure_vifs(config_devs, vals):
 config_devs.append(['device', config_vif])
 
 
 -def configure_graphics(config_image, vals):
 - """Create the config for graphic consoles.
 - """
 - args = [ 'vnc', 'vncdisplay', 'vncconsole', 'vncunused',
 - 'sdl', 'display', 'xauthority', 'vnclisten', 'vncpasswd']
 - for a in args:
 - if (vals.__dict__[a]):
 - config_image.append([a, vals.__dict__[a]])
 -
 def configure_hvm(config_image, vals):
 """Create the config for HVM devices.
 """
 args = [ 'device_model', 'pae', 'vcpus', 'boot', 'fda', 'fdb',
 'localtime', 'serial', 'stdvga', 'isa', 'nographic', 'soundhw',
 + 'vnc', 'vncdisplay', 'vncunused', 'vncconsole', 'vnclisten',
 + 'sdl', 'display', 'xauthority',
 'acpi', 'apic', 'usb', 'usbdevice', 'keymap' ]
 for a in args:
 if a in vals.__dict__ and vals.__dict__[a] is not None:
I've not been able to actually verify it since I don't currently have
a working xen-unstable build, but I don't see how it can work without
the 'vncpasswd' parameter included there in the args for configure_hvm.
Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=| 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel