Currently MoinMoin does not produce valid html
This pages has multiple bugs on it.
Contents
Steps to reproduce
Try the "Valid HTML 4.01" button on some pages. The errors slightly differ from page to page.
Example
attribute generated
URL:
http://moinmoin.wikiwikiweb.de (checked with http://validator.w3.org/)
- Error: Line 217 column 2143: there is no attribute "GENERATED".
This is true. Not sure why this is there but it is in Moin 1-6-dev in MoinMoin/theme/__init__.py Line 264:
homelink = (request.formatter.interwikilink(1, title=title, id="userhome", generated=True, *interwiki) +
Well one could just delete it, but maybe it has some use? I have searched the themes and have found no CSS that uses it. If it indeed has use I suggest not to use an illegal attribute but instead use something like class="generated". I would have done a patch but I am not sure about the meaning. Can somebody explain? -- ThiloPfennig 2006年12月07日 22:35:47
(!) fixed in 1.5 branch
script language Javascript not indicated
Pages with Javascript should define the language in a meta tag
<meta http-equiv="Content-Script-Type" content="text/javascript">
I have done a little patch that I think could solve this if i have understood things correctly:
Non unique IDs / invalid IDs
This one seems to be connected to the use of Include or MonthCalendar macros. Try e.g. validation of
there is no attribute "TYPE".
<ol type="1">
True, allowed are the attributes of %coreattrs http://www.w3.org/TR/html401/sgml/dtd.html#coreattrs
(!) I guess this won't get fixed. Unless someone has an idea how we can fix it without regressions in what wiki markup for numbered lists can do now.
Some stuff could be solved by inventing some css classes for different kind of enumeration styles maybe, but I guess the last part of the following citation won't work by CSS:
Citing HelpOnLists: start it with a number template "1.", "a.", "A.", "i." or "I.". To start a numbered list with a certain initial value, append "#value" to the number template.
My personal opinion on <OL> numbered list markup specs is that the specs are broken. -- ThomasWaldmann 2006年12月08日 13:15:48
This ol-type is "Valid HTML 4.01 Transitional" but the header in moin emitted pages specifies doctype strict (http://www.w3.org/TR/html4/strict.dtd). Should this be changed?
I second that. If we do not want to be strict we should say so! :-) -- ThiloPfennig 2006年12月08日 14:27:00 The problem is, iirc, if you don't use strict, the browsers will fall back to a complete different and slower "quirks mode". So we rather use strict mode and let the browsers simply ignore stuff they do not support (many browsers DO support this stuff).
Infact this is only the Almost Standard Mode. And also in fact if we do not set this THIS is the reason for many weirdnesses because then a browser will behave differently for images etc. So we would never have been able to resolve many issues. I suggest that we have the following patch:
Details
This Wiki.
Workaround
Discussion
- Suggestion: Make a setting for wikiconfig where one can say that one wants strict HTML.
I think this page is wrong in bugs, maybe because it does not fit the format. A bug should be closeable. This does not seem to... ;)
See also ../HTMLValidationFails
Used validators
"HTML 4.01 Strict" - as automatically detected using http://validator.w3.org/check?uri=referer
Plan
- Priority:
Assigned to: ThomasWaldmann
- Status: partly fixed in 1.5 branch