Description

edit_locking = 'lock 10' does not block a page for concurrent edits of the same user.

Steps to reproduce

1. open ?action=edit in one browser an existing page
2. open ?action=edit in another browser for the same page

the second browser gets the message that the page is locked and the editor

Example

Component selection

--- a/MoinMoin/PageEditor.py Mon Mar 24 22:51:30 2008 +0100
+++ b/MoinMoin/PageEditor.py Wed Mar 26 22:40:27 2008 +0100
@@ -1250,7 +1250,7 @@ class PageLock:
 secs_valid = self.timestamp + self.timeout - self.now

 # do we own the lock, or is it stale?
- if self.owner is None or self.uid == self.owner or secs_valid < 0:
+ if self.owner is None or secs_valid < 0:
 # create or bump the lock
 self._writeLockFile()

• general

Details

Workaround

Discussion

I think we should remove the or self.uid == self.owner The owner should not be behave different in that case.

Plan

• Priority:
• Assigned to:
• Status:

CategoryMoinMoinBug