<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

<html>

<head>

 <meta content="text/html;charset=UTF-8" http-equiv="Content-Type">

 <title></title>

</head>

<body bgcolor="#ffffff" text="#000000">

<br>

<blockquote

 cite="midbbaeab100606181252v382f58cfhdfd30a53d394fa64@mail.gmail.com"

 type="cite">

 <div>

 <blockquote class="gmail_quote"

 style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">&gt;&gt;

In abstract.c, there are many error messages like<br>

&gt;&gt;<br>

&gt;&gt; type_error("object does not support item assignment");<br>

&gt;&gt;<br>

&gt;&gt; It helps debugging if the object's type was prepended.

  <br>

&gt;&gt; Should I go through the code and try to enhance them<br>

&gt;&gt; where possible?<br>

&gt;<br>

&gt; So that's definite "perhaps"?<br>

&gt;<br>

&gt; Anyway, posted patch 1507676.<br>

  <br>

Sigh. I guess I'll have to commit it to get a second (actually,

  <br>

third, thanks Armin) opinion...</blockquote>

 <div><br>

 <br>

If you want an opinion on whether it is useful, then yes, it is

useful. Honestly I thought that was kind of obvious since better, more

informative error messages are always better as long as the verbosity

is not insane.

 <br>

 <br>

As for looking at the patch, that is just the usual time/priority

problem. =)<br>

 </div>

 </div>

</blockquote>

<br>

Also, be sure to pay attention to speed when it comes to exceptions

that are both generated and caught internally -- those need to remain

as fast and lightweight as possible (not spending time inside sprintf()

and the like). Grep for PyErr_ExceptionMatches to get a feel for which

should treated with care.  Please do not mindlessly go through and

change all the exception messaging. Instead, devote some thought to

which messages are detrimentally uninformative and are not part of time

critical execution paths.<br>

<br>

<br>

Raymond<br>

</body>

</html>