tech-pkg archive
[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index][
Old Index]
Re: Final distfile argmax fix
> Date: 2024年10月15日 11:47:35 +0100
> From: Jonathan Perkin <jperkin%mnx.io@localhost>
>
> A while back I posted a patch to correctly handle wip/grafana which now
> has so many distfiles it breaks both make and checksum.awk.
>
> I've revisited the patch, cleaned it up a bit further, made it more
> generic, and also made it work with the mktool patch for fetch, as that
> also now requires temporary files if using an older make.
>
> The current patch for review is here:
>
> https://github.com/NetBSD/pkgsrc/commit/fa88ed98c9db92f637ce54ce71c85cfc253063a3
Cool! Tiny suggestion: Can you put some additional information in the
temp file name, for attribution? E.g., maybe `pkgsrc' and the package
name? That will make it easier to track down unexplained files in
/tmp if anything is interrupted before the rm.
(Or, is there a reason it needs to be in /tmp and not in $WRKDIR?)
Home |
Main Index |
Thread Index |
Old Index