On 7 Feb 2021, at 22:47, Roland Illig <roland.illig%gmx.de@localhost> wrote: > > On 07.02.2021 18:54, Sergey A. Osokin wrote: >> https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=blob;f=unit/patches/patch-src_nxt__php__sapi.c >> looks strange not only for you, but for the Unit development team as well. >> From other side, otis@ added that patch to the package due to a build >> error on NetBSD-current. > > This one needs to be fixed properly. I won't accept any patch that > "fixes" the ctype.h compiler warning in a wrong way, and I hope no one > else will. > https://wip.pkgsrc.org/cgi-bin/gitweb.cgi?p=pkgsrc-wip.git;a=commitdiff;h=1ad42caca1fe7b670eab20d43632245e6e5bb021 Is this better? Sorry, I missed the fact that we needd an unsigned value here. I’ll keep this in mind in future. otis