tech-pkg archive
[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index][
Old Index]
Re: DESTDIR bulk build?
Joerg, are you there? This question is primarily for you. Do you
really think that Makefiles for more than 90% of more than 7000
packages should contain the following line?
PKG_DESTDIR_SUPPORT= user-destdir
For me, this looks ugly. In my view, only particular packages should
set PKG_DESTDIR_SUPPORT variable, either to 'destdir' or 'none'. The
latter option was recently suggested by David Brownlee.
>> Index: devel/gettext-tools/Makefile
>> ===================================================================
>> RCS file: /cvsroot/pkgsrc/devel/gettext-tools/Makefile,v
>> retrieving revision 1.11
>> diff -u -r1.11 Makefile
>> --- devel/gettext-tools/Makefile 3 Mar 2008 18:02:22 -0000 1.11
>> +++ devel/gettext-tools/Makefile 16 Jun 2008 05:09:41 -0000
>> @@ -10,6 +10,8 @@
>> HOMEPAGE= http://www.gnu.org/software/gettext/gettext.html
>> COMMENT= Tools for providing messages in different languages
>>
>> +PKG_DESTDIR_SUPPORT= user-destdir
>> +
>> BUILDLINK_API_DEPENDS.gettext+= gettext-lib>=0.14.5
>> CONFLICTS= gettext<0.14.5
>>
>> Index: devel/gettext-lib/Makefile
>> ===================================================================
>> RCS file: /cvsroot/pkgsrc/devel/gettext-lib/Makefile,v
>> retrieving revision 1.46
>> diff -u -r1.46 Makefile
>> --- devel/gettext-lib/Makefile 3 Mar 2008 18:02:22 -0000 1.46
>> +++ devel/gettext-lib/Makefile 16 Jun 2008 05:09:41 -0000
>> @@ -10,6 +10,8 @@
>> HOMEPAGE= http://www.gnu.org/software/gettext/gettext.html
>> COMMENT= Internationalized Message Handling Library (libintl)
>>
>> +PKG_DESTDIR_SUPPORT= user-destdir
>> +
>> CONFLICTS= gettext<=0.10.35
>>
>> PKG_INSTALLATION_TYPES= overwrite pkgviews
> Some time ago I run partial DESTDIR bulk build under NetBSD.
>
> http://mova.org/~cheusov/pub/pkgsrc-pbulk/NetBSD/current-destdir/log/20080426.0859/META/report.html
> with code in etc/distbb.local.mk that sets PKG_DESTDIR_SUPPORT to user-destdir
> if it is not defined.
> How about implementing this in pkgsrc directly, that is
> set PKG_DESTDIR_SUPPORT to user-destdir when USE_DESTDIR is set.
> IMHO, setting PKG_DESTDIR_SUPPORT in EVERY pkgsrc package is just impractical
> In other words, I suggest the following: if USE_DESTDIR is set, use
> PKG_DESTDIR_SUPPORT if it set (user-destdir/destdir/none) and set it
> to user-destdir if it not defined.
> --
> Best regards, Aleksey Cheusov.
--
Best regards, Aleksey Cheusov.
Home |
Main Index |
Thread Index |
Old Index