tech-pkg: Re: CVS commit: pkgsrc/emulators/openmsx

Subject: Re: CVS commit: pkgsrc/emulators/openmsx
To: None <tech-pkg@NetBSD.org>
From: Julio M. Merino Vidal <jmmv@menta.net>
List: tech-pkg
Date: 06/05/2004 20:19:57

On Saturday 05 June 2004 19:26, Juan Romero Pardines wrote:
> Module Name:	pkgsrc
> Committed By:	xtraeme
> Date:		Sat Jun 5 17:26:56 UTC 2004
>
> Modified Files:
> 	pkgsrc/emulators/openmsx: Makefile PLIST
>
> Log Message:
> Install a simple script into ${PREFIX}/bin to run openmsx.
- No revision bump?
- Use SH instead of /bin/sh.
- Use ECHO instead of ECHO_MSG.
- Create the script in post-build and install it in post-install. These are
 two different things conceptually, so each one belongs in a different stage.
- Why group commands? Just do two separate echo's, one with > and
 the second with >>. I.e., no (), nor \'s.
- You may want to use WRKDIR instead of WRKSRC during the creation of this
 file. (This way, you ensure that it won't conflict with other files in the
 distribution).
- And at last... the real binary doesn't take arguments? If so, it's
 impossible to pass them with this script. You should append "$@" to the
 exec call, so that arguments are passed properly. Do it even if it does
 not take arguments. Things may change in the future.
Cheers
-- 
Julio M. Merino Vidal <jmmv@menta.net>
The NetBSD Project - http://www.NetBSD.org/