Re: More disciplined use of 'getstr' and 'tsslen'
[
Date Prev][
Date Next][
Thread Prev][
Thread Next]
[
Date Index]
[
Thread Index]
- Subject: Re: More disciplined use of 'getstr' and 'tsslen'
- From: Roberto Ierusalimschy <roberto@...>
- Date: 2023年8月24日 15:18:24 -0300
> Recently there was a commit [1]:
>
> > More disciplined use of 'getstr' and 'tsslen'
> > We may want to add other string variants in the future; this change
> > documents better where the code may need to handle those variants.
>
> This commit breaks tests [2], worked before:
>
> [...]
>
> Is it expected behavior?
No, it is not. Thanks for the feedback. The 'getshrstr' nested
in the call to 'memcpy' cannot be done before we set 'shrlen',
in the next line. Strangely, valgrind did not detect this use
before set.
-- Roberto