Uploaded image for project: 'James Server'
  1. James Server
  2. JAMES-295

Missing sqlDefs wont be detected

    XMLWordPrintableJSON

Details

  • Bug
  • Status: Closed
  • Minor
  • Resolution: Fixed
  • 2.2.0
  • 2.3.0
  • None
  • None

Description

Starting at line 113 in SQLResources.java
Elements with tagname "sqlDefs" are scanned for the name of the class we want the sql-strings for.
At line 125 if this element isnt found, by assuming "sectionElement==null", an exception is thrown.
So the question is, how can sectionElement be ever null if the "sqlDef" we are looking for isnt in the xml-file?

For your convenience:
" ...
// Now get the section defining sql for the repository required.
113 NodeList sections = sqlDoc.getElementsByTagName("sqlDefs");
114 int sectionsCount = sections.getLength();
Element sectionElement = null;
for (int i = 0; i < sectionsCount; i++ ) {
sectionElement = (Element)(sections.item);
String sectionName = sectionElement.getAttribute("name");
if ( sectionName != null && sectionName.equals(sqlDefsSection) )

{ break; }

}
125 if ( sectionElement == null )

{ StringBuffer exceptionBuffer = new StringBuffer(64) .append("Error loading sql definition file. ") .append("The element named \'") .append(sqlDefsSection) .append("\' does not exist."); throw new RuntimeException(exceptionBuffer.toString()); }

... "

Attachments

Activity

People

bago Stefano Bagnara
cogens Mark Daring
Votes:
0 Vote for this issue
Watchers:
0 Start watching this issue

Dates

Created:
Updated:
Resolved: