changeset: 77560:ffc048f43a70 branch: 3.2 parent: 77538:d042bd8625f3 user: Alexander Belopolsky date: Thu Jun 21 20:34:09 2012 -0400 files: Lib/email/_parseaddr.py Lib/email/test/test_email.py Misc/NEWS description: Issue #14653: email.utils.mktime_tz() no longer relies on system mktime() when timezone offest is supplied. diff -r d042bd8625f3 -r ffc048f43a70 Lib/email/_parseaddr.py --- a/Lib/email/_parseaddr.py Thu Jun 21 20:20:25 2012 +0200 +++ b/Lib/email/_parseaddr.py Thu Jun 21 20:34:09 2012 -0400 @@ -13,7 +13,7 @@ 'quote', ] -import time +import time, calendar SPACE = ' ' EMPTYSTRING = '' @@ -152,13 +152,13 @@ def mktime_tz(data): - """Turn a 10-tuple as returned by parsedate_tz() into a UTC timestamp.""" + """Turn a 10-tuple as returned by parsedate_tz() into a POSIX timestamp.""" if data[9] is None: # No zone info, so localtime is better assumption than GMT return time.mktime(data[:8] + (-1,)) else: - t = time.mktime(data[:8] + (0,)) - return t - data[9] - time.timezone + t = calendar.timegm(data) + return t - data[9] def quote(str): diff -r d042bd8625f3 -r ffc048f43a70 Lib/email/test/test_email.py --- a/Lib/email/test/test_email.py Thu Jun 21 20:20:25 2012 +0200 +++ b/Lib/email/test/test_email.py Thu Jun 21 20:34:09 2012 -0400 @@ -2585,6 +2585,12 @@ eq(time.localtime(t)[:6], timetup[:6]) eq(int(time.strftime('%Y', timetup[:9])), 2003) + def test_mktime_tz(self): + self.assertEqual(utils.mktime_tz((1970, 1, 1, 0, 0, 0, + -1, -1, -1, 0)), 0) + self.assertEqual(utils.mktime_tz((1970, 1, 1, 0, 0, 0, + -1, -1, -1, 1234)), -1234) + def test_parsedate_y2k(self): """Test for parsing a date with a two-digit year. diff -r d042bd8625f3 -r ffc048f43a70 Misc/NEWS --- a/Misc/NEWS Thu Jun 21 20:20:25 2012 +0200 +++ b/Misc/NEWS Thu Jun 21 20:34:09 2012 -0400 @@ -73,6 +73,9 @@ Library ------- +- Issue #14653: email.utils.mktime_tz() no longer relies on system + mktime() when timezone offest is supplied. + - Fix GzipFile's handling of filenames given as bytes objects. - Issue #15101: Make pool finalizer avoid joining current thread.