changeset: 75846:a95b19b3b4cd branch: 3.2 parent: 75841:a5add01e96be user: Andrew Svetlov date: Wed Mar 21 13:23:41 2012 +0200 files: Lib/idlelib/NEWS.txt Lib/idlelib/PyShell.py Misc/NEWS description: #3573: idle now doesn't hungs if launched as: idle -e Patch by Guilherme Polo. diff -r a5add01e96be -r a95b19b3b4cd Lib/idlelib/NEWS.txt --- a/Lib/idlelib/NEWS.txt Tue Mar 20 16:49:55 2012 +0100 +++ b/Lib/idlelib/NEWS.txt Wed Mar 21 13:23:41 2012 +0200 @@ -1,3 +1,10 @@ +What's New in IDLE 3.2.3? +========================= + +- Issue #3573: IDLE hangs when passing invalid command line args + (directory(ies) instead of file(s)). + + What's New in IDLE 3.2.1? ========================= diff -r a5add01e96be -r a95b19b3b4cd Lib/idlelib/PyShell.py --- a/Lib/idlelib/PyShell.py Tue Mar 20 16:49:55 2012 +0100 +++ b/Lib/idlelib/PyShell.py Wed Mar 21 13:23:41 2012 +0200 @@ -1389,8 +1389,10 @@ if enable_edit: if not (cmd or script): - for filename in args: - flist.open(filename) + for filename in args[:]: + if flist.open(filename) is None: + # filename is a directory actually, disconsider it + args.remove(filename) if not args: flist.new() if enable_shell: diff -r a5add01e96be -r a95b19b3b4cd Misc/NEWS --- a/Misc/NEWS Tue Mar 20 16:49:55 2012 +0100 +++ b/Misc/NEWS Wed Mar 21 13:23:41 2012 +0200 @@ -28,6 +28,9 @@ Library ------- +- Issue #3573: IDLE hangs when passing invalid command line args + (directory(ies) instead of file(s)) (Patch by Guilherme Polo) + - Issue #13694: asynchronous connect in asyncore.dispatcher does not set addr attribute.