Commit 873a67d

committed

interface VersioncontrolItemDirectoryContents

it allow us to avoid the vc callback get_directory_contents

1 parent 1e3ed2c commit 873a67dCopy full SHA for 873a67d

2 files changed

Lines changed: 8 additions & 12 deletions

File tree

includes
- VersioncontrolItem.php
- classes.inc

`‎includes/VersioncontrolItem.php‎`

Lines changed: 4 additions & 12 deletions

Original file line number	Diff line number	Diff line change
`@@ -617,13 +617,8 @@ public final function getParallelItems($label_type_filter = NULL) {`
`617`	`617`	`* inside the given directory in the repository.`
`618`	`618`	`*`
`619`	`619`	`* This function is optional for VCS backends to implement, be sure to check`
`620`		`- * with versioncontrol_backend_implements($repository['vcs'], 'get_directory_contents')`
`621`		`- * if the particular backend actually implements it.`
	`620`	`+ * the return value to NULL.`
`622`	`621`	`*`
`623`		`- * @param $repository`
`624`		`- * The repository that the directory item is located in.`
`625`		`- * @param $directory_item`
`626`		`- * The parent item of the items that should be listed.`
`627`	`622`	`* @param $recursive`
`628`	`623`	`* If FALSE, only the direct children of $path will be retrieved.`
`629`	`624`	`* If TRUE, you'll get every single descendant of $path.`
`@@ -647,14 +642,11 @@ public final function getParallelItems($label_type_filter = NULL) {`
`647`	`642`	`* A real-life example of such a result array can be found`
`648`	`643`	`* in the FakeVCS example module.`
`649`	`644`	`*/`
`650`		`- public function getDirectoryContents($repository, $directory_item, $recursive = FALSE) {`
`651`		`- if (!versioncontrol_is_directory_item($directory_item)) {`
	`645`	`+ public function getDirectoryContents($recursive = FALSE) {`
	`646`	`+ if (!$this->isDirectory() \|\| $thisinstanceof VersioncontrolItemDirectoryContents) {`
`652`	`647`	`return NULL;`
`653`	`648`	`}`
`654`		`- $contents = _versioncontrol_call_backend(`
`655`		`- $repository['vcs'], 'get_directory_contents',`
`656`		`- array($repository, $directory_item, $recursive)`
`657`		`- );`
	`649`	`+ $this->_getDirectoryContents($recursive);`
`658`	`650`	`if (!isset($contents)) {`
`659`	`651`	`return NULL;`
`660`	`652`	`}`

`‎includes/classes.inc‎`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -176,3 +176,7 @@ final class VersioncontrolRepositoryCache {`
`176`	`176`	`interface VersioncontrolItemParallelItems {`
`177`	`177`	`function _getParallelItems($label_type_filter = NULL);`
`178`	`178`	`}`
	`179`	`+`
	`180`	`+interface VersioncontrolItemDirectoryContents {`
	`181`	`+ function _getDirectoryContents($recursive = FALSE);`
	`182`	`+}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Commit 873a67d

File tree

`‎includes/VersioncontrolItem.php‎`

`‎includes/classes.inc‎`

0 commit comments