I plan to enhance pdfview with extending the class.
Currently, it is not easy to change the pages' header and footer. PHP allows us to overwrite specific methods with own methods.
Beside this we can overwrite Error() so that errors get logged with watchdog.
You can get a first impression about this if you take a look at the files attached
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | pdfview_theme.inc_.txt | 4.95 KB | Tobias Maier |
| #1 | pdfview_tcpdf.inc_.txt | 990 bytes | Tobias Maier |
| pdfview.image__4.patch | 6 KB | Tobias Maier |
Comments
Tobias Maier’s picture
Comment #2
Tobias Maier commented| Status | File | Size |
|---|---|---|
| new | pdfview_theme.inc_.txt | 4.95 KB |
I moved every theme function into this include except theme_pdfview_pdf()
tzafrir’s picture
Comment #3
tzafrir commentedWow, this is a very good step for pdfview!
Right now I cannot use it, because of the messy images, the error handling, and the problems with headering, so this is very good news to hear!
Egon Bianchet’s picture
Comment #4
Egon Bianchet commentedLet's discuss the future of pdfview here before going ahead: http://groups.drupal.org/pdf
Comment #1
Tobias Maier commentedthis is the class extension