Issue 43990043: code review 43990043: fmt: use sync.Pool

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(358)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 43990043: code review 43990043: fmt: use sync.Pool (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by bradfitz

Modified:
12 years ago

Reviewers:
iant

CC:
golang-dev, iant

Visibility:
Public.

fmt: use sync.Pool Update Issue 4720

Patch Set 1 #

Patch Set 2 : diff -r 477af6a8e51f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 477af6a8e51f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 2d9fe00d6ce1 https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -39 lines)			Patch
M	src/pkg/fmt/print.go	View	1	2 chunks	+4 lines, -36 lines	0 comments	Download
M	src/pkg/fmt/scan.go	View	1	4 chunks	+6 lines, -3 lines	0 comments	Download

Total messages: 3

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2013年12月18日 18:44:22 UTC) #1

Hello golang-dev@googlegroups.com,
I'd like you to review this change to
https://go.googlecode.com/hg/

iant

LGTM

12 years ago (2013年12月18日 18:52:30 UTC) #2

LGTM

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=7f755d3040c0 *** fmt: use sync.Pool Update Issue 4720 R=golang-dev, iant CC=golang-dev https://codereview.appspot.com/43990043

12 years ago (2013年12月18日 19:09:10 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=7f755d3040c0 ***
fmt: use sync.Pool
Update Issue 4720
R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/43990043