Issue 1258041: PEP 3318 - New struct string syntax

Keyboard Shortcuts

File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view
Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue
Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Rietveld Code Review Tool

Help | Bug tracker | Discussion group | Source code | Sign in

(7)

Issues Repositories Search

Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1258041: PEP 3318 - New struct string syntax

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 7 months ago by minge

Modified:
11 years, 4 months ago

Reviewers:
dickinsm

Base URL:
http://svn.python.org/view/*checkout*/python/branches/py3k/

Visibility:
Public.

This patch implements parts of the new struct string syntax from PEP 3118. More specifically, the 'T{}' syntax and the ability to place byte-order specifiers ('<', '>', '@', '^', '!", '=') anywhere in the struct string.

Patch Set 1 #

Total comments: 2

Created: 15 years, 7 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+620 lines, -90 lines)
Doc/library/struct.rst	View	4 chunks	+55 lines, -8 lines	0 comments	Download
Lib/test/test_struct.py	View	2 chunks	+101 lines, -0 lines	0 comments	Download
Modules/_struct.c	View	21 chunks	+464 lines, -82 lines	2 comments	Download

Total messages: 2

minge

15 years, 7 months ago (2010年05月18日 12:18:21 UTC) #1

minge

http://codereview.appspot.com/1258041/diff/1/4 File Modules/_struct.c (right): http://codereview.appspot.com/1258041/diff/1/4#newcode1730 Modules/_struct.c:1730: assert(soself->s_codes != NULL); This should be 'assert(soself->s_tree->s_codes != NULL)'. ...

15 years, 7 months ago (2010年05月20日 13:58:04 UTC) #2

http://codereview.appspot.com/1258041/diff/1/4
File Modules/_struct.c (right):
http://codereview.appspot.com/1258041/diff/1/4#newcode1730
Modules/_struct.c:1730: assert(soself->s_codes != NULL);
This should be 'assert(soself->s_tree->s_codes != NULL)'.
http://codereview.appspot.com/1258041/diff/1/4#newcode1765
Modules/_struct.c:1765: assert(soself->s_codes != NULL);
This should be 'assert(soself->s_tree->s_codes != NULL)'.