homepage

Handling of long integers is broken for arguments to sqlite functions created with the create_function api. Integers passed to a sqlite function are always converted to int instead of long, which produces an incorrect value for integers outside the range of a int32 on a 32 bit machine. These failures cannot be reproduced on a 64 bit machine, since sizeof(long) == sizeof(long long).
I attached a program that demonstrates the failure. This program reports failures on a 32 bit machine, and all tests pass on a 64 bit machine.

I've never really looked at the python source before, but this is my best guess at the problem:
For the standard SELECT query:
In Modules/_sqlite/cursor.c, _pysqlite_fetch_one_row() has this code:
PY_LONG_LONG intval;
...
} else if (coltype == SQLITE_INTEGER) {
 intval = sqlite3_column_int64(self->statement->st, i);
 if (intval < INT32_MIN || intval > INT32_MAX) {
 converted = PyLong_FromLongLong(intval);
 } else {
 converted = PyInt_FromLong((long)intval);
 }
}
For user-defined function arguments:
In Modules/_sqlite/connection.c, _pysqlite_build_py_params() has this code:
PY_LONG_LONG val_int;
...
case SQLITE_INTEGER:
 val_int = sqlite3_value_int64(cur_value);
 cur_py_value = PyInt_FromLong((long)val_int);
 break;
A select query can return long integers from C to python but a user-defined function argument cannot.

Hello,
Here is a patch to fix it :) 
( and don't blame me too much if something is not correct, it's the first patch I submit :) )
Philippe

The regression tests do not work anymore in test_sqlite with the patch, I will check more in details why... sorry.

No, I made a mistake in my build, test_sqlite runs actually fine before and after the patch.

- unit tests are needed.
- Py_LONG_LONG should be used instead of "long long", and the cast removed.
- The patch assumes that longlong == int64, but is it true on all platforms?

Alternatively, val_int should have type sqlite3_int64, which is the return type of sqlite3_value_int64.

Ok I will redo a patch in the next few days with possibly type sqlite3_int64, and include tests.
Thank you for the review.

Here a new patch with sqlite3_int64 type, and unit test.

New changeset e67715b87131 by Petri Lehtinen in branch '3.2':
sqlite3: Fix 64-bit integer handling in user functions on 32-bit architectures
http://hg.python.org/cpython/rev/e67715b87131
New changeset cf12fe9ce2b0 by Petri Lehtinen in branch 'default':
Merge branch '3.2'
http://hg.python.org/cpython/rev/cf12fe9ce2b0
New changeset 789a3ea97083 by Petri Lehtinen in branch '2.7':
sqlite3: Fix 64-bit integer handling in user functions on 32-bit architectures
http://hg.python.org/cpython/rev/789a3ea97083 

Thanks for the patches, Philippe! I committed the latest one after some modifications.