homepage

/tmp/py2u... → un\icode $ ./python Lib/test/regrtest.py test_urllib2
test_urllib2
test test_urllib2 failed -- Traceback (most recent call last):
 File "/tmp/py2u... → un\icode/Lib/test/test_urllib2.py", line 36, in test_trivial
 f = urllib2.urlopen(file_url)
 File "/tmp/py2u... → un\icode/Lib/urllib2.py", line 126, in urlopen
 return _opener.open(url, data, timeout)
 File "/tmp/py2u... → un\icode/Lib/urllib2.py", line 391, in open
 response = self._open(req, data)
 File "/tmp/py2u... → un\icode/Lib/urllib2.py", line 409, in _open
 '_open', req)
 File "/tmp/py2u... → un\icode/Lib/urllib2.py", line 369, in _call_chain
 result = func(*args)
 File "/tmp/py2u... → un\icode/Lib/urllib2.py", line 1260, in file_open
 return self.open_local_file(req)
 File "/tmp/py2u... → un\icode/Lib/urllib2.py", line 1297, in open_local_file
 raise URLError(msg)
URLError: <urlopen error [Errno 2] No such file or directory: '/tmp/py2u\xe2\x80\xa6 \xe2\x86\x92 un/icode/Lib/urllib2.pyc'>
1 test failed:
 test_urllib2

Similar issue with test_ntpath.
/tmp/py2u... → un\icode $ ./python Lib/test/regrtest.py test_ntpath
test_ntpath
test test_ntpath failed -- Traceback (most recent call last):
 File "/tmp/py2u... → un\icode/Lib/test/test_ntpath.py", line 171, in test_relpath
 tester('ntpath.relpath("a", "../b")', '..\\'+currentdir+'\\a')
 File "/tmp/py2u... → un\icode/Lib/test/test_ntpath.py", line 13, in tester
 %(str(fn), str(wantResult), str(gotResult))
TestFailed: ntpath.relpath("a", "../b") should return: ..\py2u... → un\icode\a but returned: ..\icode\a
1 test failed:
 test_ntpath

This patch fixes the urllib2 test. I wasn't able to replicate the ntpath test failure.
This patch needs testing on Windows to make sure I haven't broken anything.

Can someone try to reproduce these on 2.7 as I no longer have it set up. If both problems can be reproduced I think the test_urllib2 problem should be dealt with here and a new issue opened for test_ntpath.

The ntpath test failure is replicated when the test is ran directly:
~/py/cpython1円$ ./python Lib/test/test_ntpath.py
........................s........E.....
======================================================================
ERROR: test_relpath (__main__.TestNtpath)
----------------------------------------------------------------------
Traceback (most recent call last):
 File "Lib/test/test_ntpath.py", line 314, in test_relpath
 tester('ntpath.relpath("a", "../b")', '..\\'+currentdir+'\\a')
 File "Lib/test/test_ntpath.py", line 16, in tester
 %(str(fn), str(wantResult), str(gotResult)))
test.support.TestFailed: ntpath.relpath("a", "../b") should return: ..\cpython1円\a but returned: ..1円\a
----------------------------------------------------------------------
Here is a patch with a fix of test_ntpath and with simpler fix of test_urllib2.

Oh-oh, I didn't attached my patch and cleared my working space.

> Oh-oh, I didn't attached my patch and cleared my working space.
Too bad. I did the same mistake yesterday :-/

Here is an attempt to reproduce my patch.

Ping.

Could you please look at the patch Senthil?

I reviewed the patch Serhiy. It looks good to me, You can go ahead and commit. Thanks!

New changeset 1e12c9e5bc89 by Serhiy Storchaka in branch '2.7':
Issue #7665: Fixed tests test_ntpath and test_urllib2 when ran in the
https://hg.python.org/cpython/rev/1e12c9e5bc89
New changeset 04fa56628830 by Serhiy Storchaka in branch '3.4':
Issue #7665: Fixed tests test_ntpath and test_urllib2 when ran in the
https://hg.python.org/cpython/rev/04fa56628830
New changeset 1db1cd711104 by Serhiy Storchaka in branch 'default':
Issue #7665: Fixed tests test_ntpath and test_urllib2 when ran in the
https://hg.python.org/cpython/rev/1db1cd711104 

Thank for your review Senthil.