This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2009年12月11日 12:11 by vstinner, last changed 2022年04月11日 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| _sqlite3_setdict.patch | vstinner, 2009年12月11日 12:13 | |||
| Messages (6) | |||
|---|---|---|---|
| msg96248 - (view) | Author: STINNER Victor (vstinner) * (Python committer) | Date: 2009年12月11日 12:11 | |
Methods create_function, create_aggregate, set_authorizer, set_progress_handler, create_collation of the _sqlite3.Connection class doesn't catch PyDict_SetItem/PyDict_DelItem errors. The error will be catched by next opcode/function call. The error occurs if the callback argument is not hashable. Attached patch adds the missing tests, and add unit tests. There is not unit test for Connection.create_collation() because I don't know how to test it. The call to PyDict_SetItem() is different, because the callback is not the dictionary key but the value (so it's not a problem if the callback is not hashable). |
|||
| msg96563 - (view) | Author: Gerhard Häring (ghaering) * (Python committer) | Date: 2009年12月18日 14:24 | |
Thanks! I've integrated this into pysqlite (http://code.google.com/p/pysqlite/source/detail?r=6455981b3283b26c147d949a9031a0d74ea7ffe8) and will soon push updates to the version in Python core. In my opinion this changes is not critical enough to warrant pushing it into Python 2.6. Do you agree? |
|||
| msg96564 - (view) | Author: Antoine Pitrou (pitrou) * (Python committer) | Date: 2009年12月18日 14:28 | |
It should be backported to Python 2.6, like any bug fix (and especially when it's about a crasher). |
|||
| msg97468 - (view) | Author: STINNER Victor (vstinner) * (Python committer) | Date: 2010年01月09日 18:56 | |
So, would this fix be part of python 2.7? |
|||
| msg98638 - (view) | Author: STINNER Victor (vstinner) * (Python committer) | Date: 2010年01月31日 23:54 | |
ghaering> I will soon push updates to the version in Python core. What do you mean by "soon"? |
|||
| msg100457 - (view) | Author: Gerhard Häring (ghaering) * (Python committer) | Date: 2010年03月05日 09:24 | |
Fixed in trunk now. Thanks! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:56:55 | admin | set | github: 51727 |
| 2010年03月05日 09:24:40 | ghaering | set | status: open -> closed resolution: fixed messages: + msg100457 |
| 2010年01月31日 23:54:27 | vstinner | set | messages: + msg98638 |
| 2010年01月09日 18:56:10 | vstinner | set | messages: + msg97468 |
| 2009年12月18日 14:28:29 | pitrou | set | nosy:
+ pitrou messages: + msg96564 |
| 2009年12月18日 14:24:44 | ghaering | set | assignee: ghaering messages: + msg96563 |
| 2009年12月11日 13:09:43 | pitrou | set | versions:
+ Python 2.6, Python 3.1, Python 3.2 nosy: + ghaering priority: normal type: crash stage: patch review |
| 2009年12月11日 12:13:11 | vstinner | set | files:
+ _sqlite3_setdict.patch keywords: + patch |
| 2009年12月11日 12:11:18 | vstinner | create | |