This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2008年06月12日 20:01 by steven.k.wong, last changed 2022年04月11日 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| httplib.py.patch | steven.k.wong, 2008年06月12日 20:01 | patch file for httplib.py | ||
| Messages (5) | |||
|---|---|---|---|
| msg68079 - (view) | Author: Steven K. Wong (steven.k.wong) | Date: 2008年06月12日 20:01 | |
Communicating over HTTPS at the default port of 443:
import httplib
conn = httplib.HTTPSConnection("my-secure-domain.com")
conn.request("GET", "/")
res = conn.getresponse()
In the current implementation, the Host header sent in the request is:
Host: my-secure-domain.com:443
The ":443" is unnecessary because the default port of HTTPS is 443. The
attached patch file fixes this so that the Host header sent is simply:
Host: my-secure-domain.com
|
|||
| msg68118 - (view) | Author: Senthil Kumaran (orsenthil) * (Python committer) | Date: 2008年06月13日 02:13 | |
The HTTPSConnection class derives from HTTPConnection and the methods in the HTTPConnection assume that 1) It is either over the default HTTP port or 2) Over a different port (be it different HTTP port(8080?) or 443 for HTTPS etc) and in that case it sends the port along in the request header. Thats it. So, there is no bug here. Morever, RFC 2818 states that, for HTTPS default port is 443, but the implementation are free to choose any other ports over TLS as well. Invalid bug can be closed. Thanks. |
|||
| msg68125 - (view) | Author: Steven K. Wong (steven.k.wong) | Date: 2008年06月13日 05:08 | |
Clarification: I am not saying that sending "Host: somehost:443" for an HTTPS connection at port 443 is a bug. It is in fact legal. Sending "Host: somehost" is also legal in this situation, and IMHO is the preferred behavior, because ":port" is redundant and not required when the default port of the protocol (HTTPS here) is being used. |
|||
| msg68130 - (view) | Author: Senthil Kumaran (orsenthil) * (Python committer) | Date: 2008年06月13日 07:03 | |
Yes, you are correct. I misunderstood the issue and the patch. Patch seems good to fix that. Sorry for the confusion and thank you. |
|||
| msg69379 - (view) | Author: Gregory P. Smith (gregory.p.smith) * (Python committer) | Date: 2008年07月07日 05:10 | |
fixed in trunk r64771. (and indeed the previous behavior was buggy in the extreemly rare event that someone ran a https server on port 80 the :80 should have been supplied). |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:56:35 | admin | set | github: 47344 |
| 2008年07月07日 05:10:12 | gregory.p.smith | set | status: open -> closed nosy: + gregory.p.smith messages: + msg69379 assignee: gregory.p.smith keywords: + easy resolution: accepted |
| 2008年06月13日 07:03:32 | orsenthil | set | messages: + msg68130 |
| 2008年06月13日 05:08:34 | steven.k.wong | set | messages: + msg68125 |
| 2008年06月13日 02:13:24 | orsenthil | set | nosy:
+ orsenthil messages: + msg68118 |
| 2008年06月12日 20:01:23 | steven.k.wong | create | |