This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2008年06月10日 02:06 by jml, last changed 2022年04月11日 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| how-many-values.patch | exarkun, 2009年07月27日 02:35 | |||
| Messages (7) | |||
|---|---|---|---|
| msg67885 - (view) | Author: Jonathan Lange (jml) | Date: 2008年06月10日 02:06 | |
Here's the current message: Python 2.5.2 (r252:60911, Apr 21 2008, 11:12:42) [GCC 4.2.3 (Ubuntu 4.2.3-2ubuntu7)] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> [foo] = [2, 3] Traceback (most recent call last): File "<stdin>", line 1, in <module> ValueError: too many values to unpack It would be good if the message of the ValueError contained information about how many values were expected and how many values were given. |
|||
| msg67889 - (view) | Author: Benjamin Peterson (benjamin.peterson) * (Python committer) | Date: 2008年06月10日 02:46 | |
Would you like to submit a patch? |
|||
| msg87920 - (view) | Author: Daniel Diniz (ajaksu2) * (Python triager) | Date: 2009年05月16日 20:33 | |
What would happen with infinite iterables? import itertools [foo] = itertools.count() |
|||
| msg90968 - (view) | Author: Jack Diederich (jackdied) * (Python committer) | Date: 2009年07月27日 00:12 | |
The code that raises the error is in ceval.c which is a critical path. The raise is done as soon the iterator has one more item than is needed (see Daniel Diniz's comments on infinite iterators). While the check could return more useful information for known non-infinite iterators (tuples, lists, etc) it would have to do a big if/else for all the core types (but excluding their subclasses!). If someone wants to submit that patch and a benchmark that shows no slowdown I'll reopen the bug. Until then I'm closing as WONTFIX. |
|||
| msg90972 - (view) | Author: Jean-Paul Calderone (exarkun) * (Python committer) | Date: 2009年07月27日 02:35 | |
Here's a patch implementing part of the requested feature. pystones cannot tell the difference between trunk@HEAD with or without this patch applied. Both report a maximum of 78125 pystones/second/ |
|||
| msg90974 - (view) | Author: Jack Diederich (jackdied) * (Python committer) | Date: 2009年07月27日 03:46 | |
I was looking at 3.x, JP's patch is relative to 2.x and takes a little more unpacking (a couple function calls more) but looks to me to be the same. In 2.x unpack_iterable() sets/returns an error once one item more than is required is received. It doesn't give any more information about known-length builtins than anything else. The same error is raised for million-item lists as three item lists if the expected number to unpack is two. The original feature request was that the error message be better if, say the left hand side wanted three arguments and the right hand side provided four. The ceval.c code is different between 2.x and 3.x but they both only check for 'exactly the right number, or one or more too many.' |
|||
| msg109843 - (view) | Author: Georg Brandl (georg.brandl) * (Python committer) | Date: 2010年07月10日 10:32 | |
Applied patch in r82759. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:56:35 | admin | set | github: 47321 |
| 2010年07月10日 22:01:30 | eric.araujo | set | resolution: accepted -> fixed stage: test needed -> resolved |
| 2010年07月10日 10:32:52 | georg.brandl | set | resolution: wont fix -> accepted |
| 2010年07月10日 10:32:43 | georg.brandl | set | nosy:
+ georg.brandl messages: + msg109843 |
| 2009年07月27日 03:46:22 | jackdied | set | messages: + msg90974 |
| 2009年07月27日 02:35:43 | exarkun | set | files:
+ how-many-values.patch nosy: + exarkun messages: + msg90972 keywords: + patch |
| 2009年07月27日 00:12:35 | jackdied | set | status: open -> closed nosy: + jackdied messages: + msg90968 resolution: wont fix |
| 2009年05月16日 20:33:02 | ajaksu2 | set | versions:
+ Python 2.7, Python 3.2, - Python 2.5, Python 2.4, Python 2.3 nosy: + ajaksu2 messages: + msg87920 stage: test needed |
| 2008年06月10日 02:46:25 | benjamin.peterson | set | priority: low nosy: + benjamin.peterson messages: + msg67889 |
| 2008年06月10日 02:06:05 | jml | create | |