homepage

In Python 2.5 distutils has a bug in bdist_rpm:
Generated distribution files are not listed in
``distribution.dist_files``. Thus .rpms can not be handled by other
tools, eg. ``upload``.
I need this bug fixed for automated upload of files using
<http://origo-submit.origo.ethz.ch>.
Enclosed please find a simple package to show the bug. Just run
 python setup.py bdist_rpm
and watch the (missing) output. In contrast see the output of
 python setup.py sdist
Additionally:
While untested, this should effect distutils ``upload`` command. RPMs
are not in the dist_files list and when looking at the source, there
seams to be no 'trick' to add them later.

Tarek, can this bug be fixed or is it outdated? IOW, is bdist_rpm officially discouraged or do you still accept bugfixes for it?

Even thought bdist_rpm is gone from distutils2, this is a bug that can be fixed in distutils. Adding the easy keyword to let potential contributors find this bug; hint: look at how bdist_dumb registers distributions with dist.dist_files.

I found that bdist_rpm wasn't registering distributions with dist.dist_files at all. The attached patch should be all that's needed to fix this.

Great! Could you add a test for this? By the way, do you have a machine with rpm installed? I don’t, so I won’t be able to test the patch.

Here's a patch for test_bdist_rpm.py and to check the contents of dist.dist_files

Adding a patch for 2.7

Looks good. Do you have rpm on your machine? If yes, have you run the tests successfully?

Yeah I installed rpm and have run the tests successfully.

FYI I have committed the patch to my repo and will push as soon as I can.

New changeset 26aea1825418 by Éric Araujo in branch '3.2':
Stop ignoring RPMs in distutils' upload command (#2945).
http://hg.python.org/cpython/rev/26aea1825418
New changeset 1cb9b8126534 by Éric Araujo in branch 'default':
Merge edits from 3.2 (#13716, #1040439, #2945, #13770, #6715)
http://hg.python.org/cpython/rev/1cb9b8126534 

New changeset f606d722ca23 by Éric Araujo in branch '2.7':
Stop ignoring RPMs in distutils' upload command (#2945).
http://hg.python.org/cpython/rev/f606d722ca23 

Fixed in 2.7 too, thanks to you both. If you have the time to run the tests, it would be great to get a confirmation (I’m not sure we have a buildbot with rpm installed for 2.7).