homepage

test_aead_aes_gcm (test.test_socket.LinuxKernelCryptoAPI) ... /home/angwer/cpython/Lib/unittest/case.py:600: ResourceWarning: unclosed <socket.socket fd=3, family=AddressFamily.AF_ALG, type=SocketKind.SOCK_SEQPACKET, proto=0>
 testMethod()
skipped "('[Errno 2] No such file or directory', 'aead', 'gcm(aes)')"
test_sendmsg_afalg_args (test.test_socket.LinuxKernelCryptoAPI) ... /home/angwer/cpython/Lib/unittest/case.py:600: ResourceWarning: unclosed <socket.socket fd=3, family=AddressFamily.AF_ALG, type=SocketKind.SOCK_SEQPACKET, proto=0>
 testMethod()
ok
Christian, after issue27744, there are 2 resource warnings in test_socket. test_socket.patch eliminates them.

Thanks! The first fix looks good. For the second one I'd rather wrap the test body in a with statement:
 def test_sendmsg_afalg_args(self):
 sock = socket.socket(socket.AF_ALG, socket.SOCK_SEQPACKET, 0)
 with sock:
 with self.assertRaises(TypeError):
 sock.sendmsg_afalg()
 ...

It's your code. Do what you like. :)

New changeset c515bc3b29bf by Christian Heimes in branch 'default':
Issue #28078: Silence resource warnings in test_socket. Initial patch by Xiang Zhang, thanks
https://hg.python.org/cpython/rev/c515bc3b29bf 

Thanks for the report and your patch. Let's watch the build bot.

Christian, you forget a : after else.

New changeset 8b655668c04f by Christian Heimes in branch 'default':
Issue #28078: Add missing colon
https://hg.python.org/cpython/rev/8b655668c04f 

Oh heck! I'm not sure what happened here. The test was passing locally. I can only assume that I accidentally modified the file between test run and commit.