This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2015年07月07日 00:34 by craign, last changed 2022年04月11日 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| urllib.patch | craign, 2015年07月07日 00:34 | Patch to add additional tests for urllib module | review | |
| Messages (3) | |||
|---|---|---|---|
| msg246386 - (view) | Author: Craig Northway (craign) * | Date: 2015年07月07日 00:34 | |
Patch containing additional tests for urllib module to increase code coverage for url parsing. Current coverage: Lib/urllib/parse 513 202 61% Updated coverage: Lib/urllib/parse 513 139 73% |
|||
| msg246389 - (view) | Author: Martin Panter (martin.panter) * (Python committer) | Date: 2015年07月07日 01:16 | |
Have you seen the existing test cases in /Lib/test/test_urlparse.py? If not, I don’t blame you, because of the odd test file naming and structuring. :) But I suspect some of your tests may be redundant. But you might be in a good position to suggest some comments to add somewhere explaining where all the urllib tests are. I understand the test file names come from Python 2 (where urlparse is a module). I don’t know if they were not renamed just due to laziness, or if it was to make merging patches between Python 2 and 3 easier. |
|||
| msg246391 - (view) | Author: Craig Northway (craign) * | Date: 2015年07月07日 02:10 | |
Whoops, looks like there is definitely some redundancy. I didn't notice those tests at the time I wrote these (PyCon AU last year) and while I have been grappling with getting permission to make the contributions it looks like it's been worked on a bit. I'll close this for now. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:58:18 | admin | set | github: 68767 |
| 2015年07月07日 02:10:24 | craign | set | status: open -> closed messages: + msg246391 |
| 2015年07月07日 01:16:04 | martin.panter | set | nosy:
+ martin.panter messages: + msg246389 |
| 2015年07月07日 00:37:10 | craign | set | versions: + Python 3.6 |
| 2015年07月07日 00:34:22 | craign | set | files:
+ urllib.patch keywords: + patch |
| 2015年07月07日 00:34:02 | craign | create | |