This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2015年05月28日 22:34 by eric.snow, last changed 2022年04月11日 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue24320-remove-hack.diff | eric.snow, 2015年06月02日 23:07 | review | ||
| Messages (9) | |||
|---|---|---|---|
| msg244350 - (view) | Author: Eric Snow (eric.snow) * (Python committer) | Date: 2015年05月28日 22:34 | |
In issue #23911 I worked around a bug [1] in pkg_resources (setuptools) which caused test_venv to fail when I split out importlib._bootstrap_external. That bug has now been fixed so we just(?) need to update the version of pip we're bundling and remove the hack I put in as a workaround (see msg242440). [1] https://bitbucket.org/pypa/setuptools/issue/378 |
|||
| msg244351 - (view) | Author: Eric Snow (eric.snow) * (Python committer) | Date: 2015年05月28日 22:36 | |
Would we be okay fixing this in 3.5 as well? I ask because I'm not familiar with the constraints we have on what pip is bundled. |
|||
| msg244454 - (view) | Author: Alyssa Coghlan (ncoghlan) * (Python committer) | Date: 2015年05月30日 09:58 | |
Donald updated 3.5 to pip 7 for the 1st beta, so the relevant fix may have already been included. |
|||
| msg244681 - (view) | Author: Eric Snow (eric.snow) * (Python committer) | Date: 2015年06月02日 17:39 | |
https://hg.python.org/cpython/rev/5c4ba50f6a57 I'll see if that does it. @Larry, would you be opposed to dropping the hack for beta 3? That would mean just deleting the last 2 lines in Lib/importlib/_bootstrap_external.py. |
|||
| msg244695 - (view) | Author: Larry Hastings (larry) * (Python committer) | Date: 2015年06月02日 21:49 | |
Sounds okay in theory. Is the bug in question now tested in our regression suite? |
|||
| msg244697 - (view) | Author: Eric Snow (eric.snow) * (Python committer) | Date: 2015年06月02日 21:51 | |
Yep. test_venv failures is how I found the problem in the first place. |
|||
| msg244699 - (view) | Author: Larry Hastings (larry) * (Python committer) | Date: 2015年06月02日 21:51 | |
Then you may fire when ready. |
|||
| msg244710 - (view) | Author: Eric Snow (eric.snow) * (Python committer) | Date: 2015年06月02日 23:07 | |
Hmm. Looks like the fix in setuptools/pkg_resources is 17.0. [1] The bundled pip to which we just updated is 7.0.3, which appears to bundle pkg_resources 15.0. [2] So unless I've misunderstood, the hack will have to linger for a bit longer. Here's a patch for when we get there. [1] https://bitbucket.org/pypa/setuptools/commits/tag/17.0 [2] https://github.com/pypa/pip/blob/7.0.3/pip/_vendor/README.rst |
|||
| msg275431 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2016年09月09日 20:41 | |
New changeset 821663556d87 by Eric Snow in branch 'default': Issue #24320: Drop an old setuptools-induced hack. https://hg.python.org/cpython/rev/821663556d87 |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:58:17 | admin | set | github: 68508 |
| 2016年09月09日 20:42:21 | eric.snow | set | status: open -> closed type: behavior resolution: fixed stage: patch review -> resolved |
| 2016年09月09日 20:41:47 | python-dev | set | nosy:
+ python-dev messages: + msg275431 |
| 2015年06月03日 00:52:31 | Arfrever | set | nosy:
+ Arfrever |
| 2015年06月02日 23:07:50 | eric.snow | set | files:
+ issue24320-remove-hack.diff nosy: + dstufft messages: + msg244710 keywords: + patch stage: needs patch -> patch review |
| 2015年06月02日 21:51:54 | larry | set | messages: + msg244699 |
| 2015年06月02日 21:51:25 | eric.snow | set | messages: + msg244697 |
| 2015年06月02日 21:50:00 | larry | set | messages: + msg244695 |
| 2015年06月02日 17:39:58 | eric.snow | set | messages: + msg244681 |
| 2015年05月30日 09:58:57 | ncoghlan | set | messages: + msg244454 |
| 2015年05月28日 22:41:03 | serhiy.storchaka | set | nosy:
+ larry |
| 2015年05月28日 22:36:07 | eric.snow | set | messages: + msg244351 |
| 2015年05月28日 22:34:56 | eric.snow | create | |