This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2014年06月03日 14:42 by foom, last changed 2022年04月11日 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| finduni.py | loewis, 2014年06月13日 20:35 | |||
| 21652.patch | Vladimir.Iofik, 2014年06月28日 12:48 | review | ||
| Messages (14) | |||
|---|---|---|---|
| msg219693 - (view) | Author: James Y Knight (foom) | Date: 2014年06月03日 14:42 | |
The change done for issue9291 in Python 2.7.7 caused the mimetypes.types_map dict to change to contain a mixture of str and unicode objects, rather than just str, as it always had before. This causes twisted.web to crash when serving static files on Windows. See https://twistedmatrix.com/trac/ticket/7461 for the bug report against Twisted. |
|||
| msg220353 - (view) | Author: Gavin Carothers (gcarothers) | Date: 2014年06月12日 14:20 | |
Issue also exists in Pyramid (any wsgi server/framework) See https://github.com/Pylons/pyramid/issues/1360 for Pyramid bug. |
|||
| msg220383 - (view) | Author: Ned Deily (ned.deily) * (Python committer) | Date: 2014年06月12日 20:21 | |
If there is a regression to be fixed, there needs to be a patch with a test. Anyone? |
|||
| msg220455 - (view) | Author: James Y Knight (foom) | Date: 2014年06月13日 15:32 | |
Reverting the incorrect commit which caused the regression would be a good start. |
|||
| msg220458 - (view) | Author: R. David Murray (r.david.murray) * (Python committer) | Date: 2014年06月13日 15:53 | |
If I understand correct that patch was itself attempting to fix a regression ;) |
|||
| msg220462 - (view) | Author: Tim Golden (tim.golden) * (Python committer) | Date: 2014年06月13日 16:03 | |
Only if you have something better to put in its place! That commit was fixing an existing problem; perhaps not your problem, but someone's. To revert it would simply move the pain around. I hope to be able to work on this fairly soon. If anyone else wants to propose an approach to take this forward, they're welcome to do so. |
|||
| msg220466 - (view) | Author: Jean-Paul Calderone (exarkun) * (Python committer) | Date: 2014年06月13日 16:51 | |
> That commit was fixing an existing problem; perhaps not your problem, but someone's. To revert it would simply move the pain around. Doesn't the very same logic apply to the original commit? > I hope to be able to work on this fairly soon. Thanks. Much appreciated. |
|||
| msg220469 - (view) | Author: Vladimir Iofik (Vladimir.Iofik) * | Date: 2014年06月13日 16:59 | |
Did anyone here managed to reproduce the issue? I tired but I have failed to. I'm still trying though. Anyway I'd start from investigating why a function EnumKey returns Unicode object while according to documentation it should return string. |
|||
| msg220496 - (view) | Author: Martin v. Löwis (loewis) * (Python committer) | Date: 2014年06月13日 20:35 | |
I can reproduce the issue with the attached script. The problem is not that EnumKey returns a Unicode string (which it never does), but that QueryValueEx returns a Unicode string. See http://hg.python.org/cpython/rev/18cfc2a42772 for the actual change in question. |
|||
| msg220539 - (view) | Author: Vladimir Iofik (Vladimir.Iofik) * | Date: 2014年06月14日 09:02 | |
Thanks, Martin. I didn't read the final with enough care. I think the second part of changes (the ones that are around QueryValueEx) should be rolled back. I believe the code was correct at that part. Tim, what do you think? |
|||
| msg221314 - (view) | Author: Benjamin Peterson (benjamin.peterson) * (Python committer) | Date: 2014年06月22日 21:29 | |
Vladimir, if you could provide a patch implementing your proposed rollback, that would be appreciated. |
|||
| msg221783 - (view) | Author: Vladimir Iofik (Vladimir.Iofik) * | Date: 2014年06月28日 12:48 | |
Finally I got environment and some time. Attaching patch. |
|||
| msg221890 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2014年06月29日 20:04 | |
New changeset 1aafbdfba25a by Benjamin Peterson in branch '2.7': don't allow unicode into type_map on Windows (closes #21652) http://hg.python.org/cpython/rev/1aafbdfba25a |
|||
| msg221892 - (view) | Author: Benjamin Peterson (benjamin.peterson) * (Python committer) | Date: 2014年06月29日 20:04 | |
Thanks Vladimir; I really appreciate your work on these issues. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:58:04 | admin | set | github: 65851 |
| 2014年06月29日 20:04:39 | benjamin.peterson | set | messages: + msg221892 |
| 2014年06月29日 20:04:02 | python-dev | set | status: open -> closed resolution: fixed messages: + msg221890 stage: resolved |
| 2014年06月28日 12:48:54 | Vladimir.Iofik | set | files:
+ 21652.patch keywords: + patch messages: + msg221783 |
| 2014年06月22日 21:29:48 | benjamin.peterson | set | messages: + msg221314 |
| 2014年06月14日 09:02:54 | Vladimir.Iofik | set | messages: + msg220539 |
| 2014年06月13日 20:35:42 | loewis | set | files:
+ finduni.py messages: + msg220496 |
| 2014年06月13日 16:59:45 | Vladimir.Iofik | set | nosy:
+ Vladimir.Iofik messages: + msg220469 |
| 2014年06月13日 16:51:25 | exarkun | set | messages: + msg220466 |
| 2014年06月13日 16:03:33 | tim.golden | set | messages: + msg220462 |
| 2014年06月13日 15:53:44 | r.david.murray | set | messages: + msg220458 |
| 2014年06月13日 15:32:14 | foom | set | messages: + msg220455 |
| 2014年06月13日 07:36:14 | tim.golden | set | assignee: tim.golden |
| 2014年06月12日 20:21:46 | ned.deily | set | priority: normal -> release blocker nosy: + benjamin.peterson, ned.deily messages: + msg220383 |
| 2014年06月12日 14:20:27 | gcarothers | set | nosy:
+ gcarothers messages: + msg220353 |
| 2014年06月03日 18:03:31 | exarkun | set | nosy:
+ exarkun |
| 2014年06月03日 14:42:12 | foom | create | |