homepage

I noticed this code in Objects/object.c today:
 /* Hack to force loading of pycapsule.o */
 PyTypeObject *_PyCapsule_hack = &PyCapsule_Type;
What is this doing? Note that PyCapsule_Type is referred to inside _Py_ReadyTypes(), so there's already a reference to it from this module. This global seems redundant.
Attached is a patch that removes it. Trunk compiles and all tests pass with it applied, though I only tried on 64-bit Linux so I concede if this is handling some obscure edge case I probably wouldn't have hit it.

I've taken a bit of a liberty and picked the names of the last three guys who've worked on this file as I assume they're best qualified to comment.

I'm inclined to suggest you try removing it and see what happens on the buildbots.
I remember we used to have a few interesting challenges at my old job convincing Visual Studio that we really were using a type definition and we should export it from the DLL. That was way back in the VC6 days though, so I expect the situation has improved by now.
Added Steve to the nosy list to see if he's aware of any current Windows specific reasons this might be needed.

No current reasons I'm aware of (apart from not having a working up-to-date Windows buildbot right now - blocked on #23524) so I'd say go ahead. Pull it out and see what breaks.
The fact that the comment says "pycapsule.o" and not "pycapsule.obj" probably means this wasn't a Windows issue in the first place.

You give me too much credit. I'm the chimp who put it there in the first place. Though, admittedly, it was a copy&paste job based on the ancient CObject.
My guess is this was very helpful in 1.4, or something. ;-)

New changeset b22755f8ab5f by Larry Hastings in branch 'default':
Issue #21293: Remove unnecessary "capsule hack".
https://hg.python.org/cpython/rev/b22755f8ab5f 

Yeah, I went ahead and checked this in. I'm living life on the *edge*.
To the EXTREME!