This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2014年04月01日 03:04 by landersson, last changed 2022年04月11日 14:58 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| timeout.py | landersson, 2014年04月01日 03:04 | resource usage issue reproduction code | ||
| create_connection_close.patch | vstinner, 2014年04月04日 16:39 | review | ||
| close2.patch | vstinner, 2014年04月04日 16:52 | review | ||
| close-3.patch | vstinner, 2014年04月09日 01:04 | review | ||
| Messages (8) | |||
|---|---|---|---|
| msg215291 - (view) | Author: Lars Andersson (landersson) | Date: 2014年04月01日 03:04 | |
The attached code generates an unclosed socket ResourceWarning when timing out trying to connect to an unreachable address. Probably not terribly serious, but in my case, it generates distracting warnings during unit testing. I have looked briefly at the asyncio code but it's not immediately obvious to me how to fix it. |
|||
| msg215534 - (view) | Author: STINNER Victor (vstinner) * (Python committer) | Date: 2014年04月04日 16:39 | |
Here is a patch for Python 3.5. It should be applied to Python 3.4 too. |
|||
| msg215535 - (view) | Author: STINNER Victor (vstinner) * (Python committer) | Date: 2014年04月04日 16:52 | |
BaseEventLoop.create_datagram_endpoint() and _UnixSelectorEventLoop.create_unix_server() have the same bug. close2.patch fixes these methods but also modify socketpair() to ensure that the 2 sockets are closed on error. I didn't audit the whole asyncio module. Note: BaseEventLoop.create_server() uses a different approach: a "completed" flag with a try/finally block. |
|||
| msg215674 - (view) | Author: Lars Andersson (landersson) | Date: 2014年04月07日 00:52 | |
Thanks Victor, that fixes my problem. I've started using tulip/master as part of my project as that also solves other issues I have with the default asyncio of python 3.4.0, but hopefully this fix will into tulip/master as well as python 3.4.1 / 3.5. |
|||
| msg215790 - (view) | Author: STINNER Victor (vstinner) * (Python committer) | Date: 2014年04月09日 01:04 | |
Updated patch (close-3.patch) combining create_connection_close.patch and close2.patch and adding unit tests. I also improved the create_connection() test to raise the TimeoutError on connect() (loop.sock_connect), not on sock.set_blocking(). |
|||
| msg219307 - (view) | Author: STINNER Victor (vstinner) * (Python committer) | Date: 2014年05月28日 21:47 | |
Can someone review close-3.patch please? |
|||
| msg219725 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2014年06月03日 22:16 | |
New changeset d0dd3eb5b5ef by Victor Stinner in branch '3.4': Issue #21119: asyncio now closes sockets on errors http://hg.python.org/cpython/rev/d0dd3eb5b5ef New changeset bbd773ed9584 by Victor Stinner in branch '3.4': Issue #21119: asyncio: Make sure that socketpair() close sockets on error http://hg.python.org/cpython/rev/bbd773ed9584 New changeset 8b40483d9a08 by Victor Stinner in branch 'default': Merge 3.4: Issue #21119, fix ResourceWarning in asyncio http://hg.python.org/cpython/rev/8b40483d9a08 |
|||
| msg219726 - (view) | Author: STINNER Victor (vstinner) * (Python committer) | Date: 2014年06月03日 22:21 | |
I fixed the issues in Tulip, Python 3.4 and 3.5. Thanks for the report. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:58:01 | admin | set | github: 65318 |
| 2014年06月03日 22:21:17 | vstinner | set | status: open -> closed resolution: works for me -> fixed messages: + msg219726 |
| 2014年06月03日 22:16:54 | python-dev | set | nosy:
+ python-dev messages: + msg219725 |
| 2014年05月28日 21:47:53 | vstinner | set | messages: + msg219307 |
| 2014年04月09日 01:04:55 | vstinner | set | files:
+ close-3.patch messages: + msg215790 |
| 2014年04月07日 00:52:04 | landersson | set | resolution: works for me messages: + msg215674 |
| 2014年04月04日 16:52:08 | vstinner | set | files:
+ close2.patch messages: + msg215535 |
| 2014年04月04日 16:39:26 | vstinner | set | files:
+ create_connection_close.patch versions: + Python 3.5 nosy: + yselivanov, gvanrossum, vstinner messages: + msg215534 keywords: + patch |
| 2014年04月01日 03:04:44 | landersson | create | |