homepage

The patch is a proof of concept for PBKDF2 support for the OpenSSL variant of hashlib. It's a thin wrapper around PKCS5_PBKDF2_HMAC() and is deliberately designed as low level API with bytes and input and output types. High level wrappers can do the conversation and choose sensible values for salt, iterations and key length.

Please use the "y*" format, not "y#".
Also, I would lower-case "pbkdf2", just as we already lower-case "md5", "sha1", etc.

Done

The patch looks good at first sight. It still needs docs and tests :)
Just one thing: are we sure PKCS5_PBKDF2_HMAC is defined on old OpenSSL versions, or does it need a #ifdef?

Here is a new patch with tests, documentation and some minor improvements. The last argument is now called dklen. If dklen is omitted or None than dklen is set to digest size of the hash algorithm.

Fixed copy n' paste bug in docs.

New changeset 5fd56d6d3fce by Christian Heimes in branch 'default':
Issue #18582: Add 'pbkdf2_hmac' to the hashlib module.
http://hg.python.org/cpython/rev/5fd56d6d3fce 

Thanks Antoine!

New changeset 0a26ef834a49 by Christian Heimes in branch 'default':
Issue #18582: provide a faster C implementation of pbkdf2_hmac that works with OpenSSL < 1.0
http://hg.python.org/cpython/rev/0a26ef834a49 

New changeset 88fac1574049 by Christian Heimes in branch 'default':
Issue #18582: HMAC_CTX_copy() is not available on OpenSSL < 1.0
http://hg.python.org/cpython/rev/88fac1574049 

New changeset a15fcb847515 by Christian Heimes in branch 'default':
Issue #18582: skip test of _hashlib.pbkdf2_hmac if OpenSSL is not available or too old
http://hg.python.org/cpython/rev/a15fcb847515 

New changeset 07fa1ed0d551 by Christian Heimes in branch 'default':
Issue #18582: fix memory leak in pbkdf2 code
http://hg.python.org/cpython/rev/07fa1ed0d551