This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2007年08月21日 09:57 by indy90, last changed 2022年04月11日 14:56 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| rb.diff | skip.montanaro, 2008年06月18日 00:25 | |||
| Messages (15) | |||
|---|---|---|---|
| msg53045 - (view) | Author: Indy (indy90) | Date: 2007年08月21日 09:57 | |
Some performance and readability fixes to robotparser.py. |
|||
| msg56008 - (view) | Author: Jim Jewett (jimjjewett) | Date: 2007年09月18日 20:03 | |
On line 108 (new 104), spaces should probably be added on both sides of the comparison operator, instead of only after the ">=". The "%s" changes might end up getting changed again as part of 2to3, but this is a clear improvement over status quo, particularly with the loops. I recommend applying. |
|||
| msg56706 - (view) | Author: Aristotelis Mikropoulos (Indy) | Date: 2007年10月24日 11:06 | |
Yes, of course I meant spaces on both sides of ">=", it was just a typo of mine. I am sorry. I am glad you recommend applying my patch. I hope it helps. |
|||
| msg59025 - (view) | Author: Aristotelis Mikropoulos (Indy) | Date: 2007年12月28日 14:07 | |
Also, I would like to tell you that my new account name is "Indy", and not "indy90" anymore (I changed since this issue tracker moved from SourceForge to here). So, thanks again and I hope this patch will be helpful. |
|||
| msg68088 - (view) | Author: Aristotelis Mikropoulos (Indy) | Date: 2008年06月12日 20:59 | |
So, finally, will this patch be applied? |
|||
| msg68090 - (view) | Author: Benjamin Peterson (benjamin.peterson) * (Python committer) | Date: 2008年06月12日 21:03 | |
Can we have a unified diff as per http://www.python.org/dev/patches/? |
|||
| msg68147 - (view) | Author: Aristotelis Mikropoulos (Indy) | Date: 2008年06月13日 12:25 | |
Sure. |
|||
| msg68321 - (view) | Author: Aristotelis Mikropoulos (Indy) | Date: 2008年06月17日 13:11 | |
Is the patch, now, in an acceptable format? |
|||
| msg68322 - (view) | Author: Benjamin Peterson (benjamin.peterson) * (Python committer) | Date: 2008年06月17日 13:17 | |
Skip, are you still maintaining this? |
|||
| msg68323 - (view) | Author: Aristotelis Mikropoulos (Indy) | Date: 2008年06月17日 13:42 | |
Yes, why not? Actually, I am the original author of the patch, but I changed my username like I said above (in a previous post). |
|||
| msg68324 - (view) | Author: Aristotelis Mikropoulos (Indy) | Date: 2008年06月17日 13:43 | |
Oh, I am sorry, I thought you were talking to me. Excuse me. |
|||
| msg68326 - (view) | Author: Raymond Hettinger (rhettinger) * (Python committer) | Date: 2008年06月17日 14:04 | |
These changes mostly look fine but shouldn't go it until after the beta. This is really the wrong time in the release cycle to be making minor spacing changes and making it harder to get a meaningful "svn ann". BTW, the first change should go the distance and use map() instead of a list comprehension: lines = map(str.strip, f) |
|||
| msg68327 - (view) | Author: Aristotelis Mikropoulos (Indy) | Date: 2008年06月17日 14:34 | |
OK |
|||
| msg68356 - (view) | Author: Skip Montanaro (skip.montanaro) * (Python triager) | Date: 2008年06月18日 00:25 | |
I suppose I'm as good a person to continue maintaining this as any, though my time is largely spent doing other stuff these days. The patch doesn't apply cleanly right now and lots of the changes it suggests have been made already (or done in slightly different ways). I've attached a simplified patch which takes care of the only two changes I see which seem to still be worthwhile. Assigning to Benjamin and changing resolution to "remind" so he can either apply himself when the time is right or toss it back to me. (I apologize, but I am not intimately tuned into the alpha/beta release process at the moment.) Skip |
|||
| msg69604 - (view) | Author: Benjamin Peterson (benjamin.peterson) * (Python committer) | Date: 2008年07月12日 23:42 | |
OK. I committed the patch in r64901. Thanks for the work! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:56:26 | admin | set | github: 45335 |
| 2008年07月12日 23:42:10 | benjamin.peterson | set | status: open -> closed resolution: remind -> accepted messages: + msg69604 |
| 2008年06月18日 00:25:30 | skip.montanaro | set | files: - robotparser.py.patch |
| 2008年06月18日 00:25:25 | skip.montanaro | set | files: - robotparser.py.patch |
| 2008年06月18日 00:25:17 | skip.montanaro | set | files:
+ rb.diff assignee: skip.montanaro -> benjamin.peterson resolution: remind messages: + msg68356 |
| 2008年06月17日 14:34:20 | Indy | set | messages: + msg68327 |
| 2008年06月17日 14:04:52 | rhettinger | set | priority: normal -> low nosy: + rhettinger messages: + msg68326 versions: + Python 2.6, - Python 2.5 |
| 2008年06月17日 13:43:41 | Indy | set | messages: + msg68324 |
| 2008年06月17日 13:42:58 | Indy | set | messages: + msg68323 |
| 2008年06月17日 13:17:08 | benjamin.peterson | set | assignee: skip.montanaro messages: + msg68322 nosy: + skip.montanaro |
| 2008年06月17日 13:11:58 | Indy | set | messages: + msg68321 |
| 2008年06月13日 12:25:37 | Indy | set | files:
+ robotparser.py.patch messages: + msg68147 |
| 2008年06月12日 21:03:38 | benjamin.peterson | set | nosy:
+ benjamin.peterson messages: + msg68090 |
| 2008年06月12日 20:59:15 | Indy | set | messages: + msg68088 |
| 2007年12月28日 14:07:23 | Indy | set | messages: + msg59025 |
| 2007年10月24日 11:06:56 | Indy | set | nosy:
+ Indy messages: + msg56706 |
| 2007年09月18日 20:03:02 | jimjjewett | set | nosy:
+ jimjjewett messages: + msg56008 |
| 2007年08月21日 09:57:02 | indy90 | create | |