homepage

This issue tracker has been migrated to GitHub , and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: _cursesmodule Fails to Build on GCC 2.95 (static)
Type: compile error Stage: resolved
Components: Extension Modules Versions: Python 3.4, Python 3.5
process
Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: Nosy List: BreamoreBoy, Jeffrey.Armstrong, neologix
Priority: normal Keywords: patch

Created on 2013年03月10日 14:18 by Jeffrey.Armstrong, last changed 2022年04月11日 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
curses.patch Jeffrey.Armstrong, 2013年03月10日 14:18 Patch to correct compile error
Messages (5)
msg183877 - (view) Author: Jeffrey Armstrong (Jeffrey.Armstrong) * Date: 2013年03月10日 14:18
When compiling Modules/_cursesmodule.c as a static module with GCC 2.95.3, an error is encountered on line 2260 in PyCurses_GetWin. The error occurs because the PyCursesInitialised macro appears prior _Py_IDENTIFIER(read), which is actually a variable declaration. Switching the order of the statements fixes the issue.
In all other functions within Modules/_cursesmodule.c, PyCursesInitialised always appears after all variable declarations.
This bug was encountered on the platform m68k-atari-mint using Python 3.3.0 and GCC 2.95.3.
msg223260 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2014年07月16日 19:40
Can we have a review of the one line patch please.
msg223695 - (view) Author: Charles-François Natali (neologix) * (Python committer) Date: 2014年07月22日 20:51
Jerrfey, thanks for your patch, but apparently in the - long - meantime, the declaration has already been moved up.
msg223697 - (view) Author: Jeffrey Armstrong (Jeffrey.Armstrong) * Date: 2014年07月22日 20:59
Next time I see a bug I'll be sure to wait rather than actually submit a patch...
msg223699 - (view) Author: Charles-François Natali (neologix) * (Python committer) Date: 2014年07月22日 21:16
> Jeffrey Armstrong added the comment:
>
> Next time I see a bug I'll be sure to wait rather than actually submit a patch...
I understand your frustration, but please don't do that: you have to
understand that we don't have any automatic reminder of issues, so it
can happen that some go unnoticed, especially if no core developer is
assigned.
Is this happens in the future, simply send an email on the python-dev
mailing list saying that you've got a patch waiting for review, this
shoud do the trick.
History
Date User Action Args
2022年04月11日 14:57:42adminsetgithub: 61593
2014年07月22日 21:16:39neologixsetmessages: + msg223699
2014年07月22日 20:59:17Jeffrey.Armstrongsetmessages: + msg223697
2014年07月22日 20:51:21neologixsetstatus: open -> closed

nosy: + neologix
messages: + msg223695

resolution: out of date
stage: resolved
2014年07月16日 19:40:01BreamoreBoysetnosy: + BreamoreBoy

messages: + msg223260
versions: + Python 3.4, Python 3.5, - Python 3.3
2013年03月11日 01:49:51Jeffrey.Armstrongsetcomponents: + Extension Modules, - Build
2013年03月10日 14:18:23Jeffrey.Armstrongcreate

AltStyle によって変換されたページ (->オリジナル) /