This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2012年08月03日 00:20 by chris.jerdonek, last changed 2022年04月11日 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| issue-15543-1.patch | chris.jerdonek, 2012年08月06日 03:44 | review | ||
| issue-15543-2.patch | chris.jerdonek, 2012年08月07日 00:43 | review | ||
| issue-15543-3.patch | chris.jerdonek, 2012年08月14日 01:02 | review | ||
| issue-15543-4.patch | chris.jerdonek, 2012年08月14日 03:41 | review | ||
| issue-15543-5.patch | chris.jerdonek, 2012年08月14日 10:00 | review | ||
| issue-15543-6-py27.patch | chris.jerdonek, 2012年08月15日 13:02 | |||
| issue-15543-6-py32.patch | chris.jerdonek, 2012年08月15日 14:04 | |||
| issue-15543-6-py33-delta.patch | chris.jerdonek, 2012年08月15日 14:08 | |||
| Messages (26) | |||
|---|---|---|---|
| msg167279 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2012年08月03日 00:20 | |
"Universal newlines" of PEP 278 does not seem to have a central, linkable description within the documentation. In particular, there does not seem to be a glossary entry or any index entries for it. The main documentation seems to be in the middle of the documentation for the open() built-in function: http://docs.python.org/dev/library/functions.html?highlight=open#open But this does not feature prominently when searching for universal newlines in the "Quick Search". This would allow us, for example, to reference and link to an explanation of universal newlines in the documentation for str.splitlines(): http://docs.python.org/dev/library/stdtypes.html#str.splitlines I would be happy to provide a patch. |
|||
| msg167294 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) | Date: 2012年08月03日 07:42 | |
See issue15204. |
|||
| msg167298 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2012年08月03日 08:33 | |
Since universal newline mode is discouraged and getting deprecated in the built-in open() function, the "central" place for describing universal newlines should probably not be the documentation for the open() method. I am leaning towards a glossary entry. The io.TextIOWrapper class is another candidate: http://docs.python.org/dev/library/io.html#io.TextIOWrapper |
|||
| msg167376 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2012年08月03日 23:10 | |
See also: f17a1410ebe5 |
|||
| msg167377 - (view) | Author: Antoine Pitrou (pitrou) * (Python committer) | Date: 2012年08月03日 23:12 | |
> Since universal newline mode is discouraged and getting deprecated in > the built-in open() function There may (or may not :-)) be a misunderstanding. Universal newlines are not discouraged; it's the legacy "U" flag which is deprecated. |
|||
| msg167380 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2012年08月03日 23:33 | |
> There may (or may not :-)) be a misunderstanding. Universal newlines are not discouraged; it's the legacy "U" flag which is deprecated. Already understood. :) (I said "in the built-in open() function" above and meant "mode" as in "flag".) I nosied you only because you copy and pasted information about universal newlines that might benefit from a glossary entry or some such about universal newlines. |
|||
| msg167390 - (view) | Author: Antoine Pitrou (pitrou) * (Python committer) | Date: 2012年08月04日 00:44 | |
> I nosied you only because you copy and pasted information about > universal newlines that might benefit from a glossary entry or some > such about universal newlines. Yes, it might benefit from a glossary entry. On the other hand, the details of the *newline* argument should probably remain in the API descriptions themselves. |
|||
| msg167393 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2012年08月04日 02:21 | |
> On the other hand, the details of the *newline* argument should probably remain in the API descriptions themselves. Correct. It would be a high-level entry for "universal newlines" -- independent of any API and suitable for linking to wherever universal newlines are mentioned (e.g. in the documentation of str.splitlines()). |
|||
| msg167534 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2012年08月06日 03:44 | |
Attaching a patch for review. |
|||
| msg167592 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2012年08月07日 00:43 | |
Updating patch to current tip. |
|||
| msg168162 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2012年08月14日 01:02 | |
Updating patch to latest again. |
|||
| msg168165 - (view) | Author: R. David Murray (r.david.murray) * (Python committer) | Date: 2012年08月14日 02:02 | |
Thanks for working on this. I see nothing wrong with using 'universal newlines mode' as the term, which would simplify the markup. |
|||
| msg168168 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2012年08月14日 02:42 | |
Sure, you're welcome. And sounds good, I'll change it. The singular was the prevailing form, but you're right that there is no reason we can't change it. |
|||
| msg168169 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2012年08月14日 03:11 | |
Is it worth standardizing on "universal newlines mode" in the code as well (docstrings, etc)? There are about ten occurrences of "universal newline mode" that would need to be changed. |
|||
| msg168171 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2012年08月14日 03:41 | |
Here is a new patch with David's suggested change (just for doc files though). |
|||
| msg168187 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2012年08月14日 10:00 | |
Updating patch to tip again. |
|||
| msg168248 - (view) | Author: R. David Murray (r.david.murray) * (Python committer) | Date: 2012年08月15日 01:01 | |
Yeah, we might as well be consistent, though it's not a big deal either way. I'd prefer that as a separate patch. Any interest in backporting this to 2.7? Being so close to final release on 3.2 I think we can skip 3.2, unless you feel like doing it. |
|||
| msg168250 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2012年08月15日 01:09 | |
Sure, I'd be happy to do both 2.7 and 3.2. I can upload the patch for the default branch as a delta to apply after the 3.2 change has been forward-ported from 3.2 to default. Thanks for taking an interest in this! |
|||
| msg168290 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2012年08月15日 13:02 | |
Here is the patch for 2.7. |
|||
| msg168296 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2012年08月15日 14:08 | |
And here are the 3.2 patch and the 3.3 "delta" after forward-porting. Note that to forward-port the 3.2 patch to the default 3.3 branch, you can simply drop the changes to the file Doc/library/bz2.rst. I think that is the only conflict. |
|||
| msg168308 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2012年08月15日 15:23 | |
New changeset 273df9789796 by R David Murray in branch '3.2': #15543: glossary entry for and 'universal newlines', and links to it. http://hg.python.org/cpython/rev/273df9789796 New changeset e67042b6ad02 by R David Murray in branch '3.2': #15543: reflow paragraphs. http://hg.python.org/cpython/rev/e67042b6ad02 New changeset 04a0255de9b8 by R David Murray in branch 'default': Merge #15543: glossary entry for and 'universal newlines', and links to it. http://hg.python.org/cpython/rev/04a0255de9b8 New changeset 37df50bc4ea0 by R David Murray in branch 'default': #15543: additional link in subprocess docs. http://hg.python.org/cpython/rev/37df50bc4ea0 New changeset a2efe5eeb876 by R David Murray in branch 'default': #15543: reflow paragraph. http://hg.python.org/cpython/rev/a2efe5eeb876 New changeset 8795cd3b4c8c by R David Murray in branch '2.7': #15543: glossary entry for and 'universal newlines', and links to it. http://hg.python.org/cpython/rev/8795cd3b4c8c New changeset 35d8a638b0e2 by R David Murray in branch '2.7': #15543: reflow paragraphs. http://hg.python.org/cpython/rev/35d8a638b0e2 |
|||
| msg168309 - (view) | Author: R. David Murray (r.david.murray) * (Python committer) | Date: 2012年08月15日 15:25 | |
Thanks Chris. |
|||
| msg168310 - (view) | Author: Andrew Svetlov (asvetlov) * (Python committer) | Date: 2012年08月15日 15:30 | |
Good work. |
|||
| msg168311 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2012年08月15日 15:30 | |
Thanks, David! Also, can/did you check that reflows like these still link to the glossary correctly? + :func:`input` function to allow opening files in binary or :term:`universal + newlines` mode. Another new parameter, *openhook*, lets you use a function I tried to avoid breaking role markups like these to be safe |
|||
| msg168312 - (view) | Author: Andrew Svetlov (asvetlov) * (Python committer) | Date: 2012年08月15日 15:33 | |
Yes, it is processed correctly. |
|||
| msg168342 - (view) | Author: Éric Araujo (eric.araujo) * (Python committer) | Date: 2012年08月15日 22:48 | |
Great patch! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:33 | admin | set | github: 59748 |
| 2012年08月15日 22:48:55 | eric.araujo | set | nosy:
+ eric.araujo messages: + msg168342 |
| 2012年08月15日 15:33:34 | asvetlov | set | messages: + msg168312 |
| 2012年08月15日 15:30:44 | chris.jerdonek | set | messages: + msg168311 |
| 2012年08月15日 15:30:41 | asvetlov | set | messages: + msg168310 |
| 2012年08月15日 15:25:03 | r.david.murray | set | status: open -> closed type: enhancement messages: + msg168309 resolution: fixed stage: patch review -> resolved |
| 2012年08月15日 15:23:53 | python-dev | set | nosy:
+ python-dev messages: + msg168308 |
| 2012年08月15日 14:08:31 | chris.jerdonek | set | files:
+ issue-15543-6-py33-delta.patch messages: + msg168296 |
| 2012年08月15日 14:04:46 | chris.jerdonek | set | files: + issue-15543-6-py32.patch |
| 2012年08月15日 13:02:50 | chris.jerdonek | set | files:
+ issue-15543-6-py27.patch messages: + msg168290 |
| 2012年08月15日 01:09:16 | chris.jerdonek | set | messages:
+ msg168250 versions: + Python 2.7, Python 3.2 |
| 2012年08月15日 01:01:26 | r.david.murray | set | messages: + msg168248 |
| 2012年08月14日 10:00:19 | chris.jerdonek | set | files:
+ issue-15543-5.patch messages: + msg168187 |
| 2012年08月14日 03:41:54 | chris.jerdonek | set | files:
+ issue-15543-4.patch messages: + msg168171 |
| 2012年08月14日 03:11:35 | chris.jerdonek | set | messages: + msg168169 |
| 2012年08月14日 02:42:52 | chris.jerdonek | set | messages: + msg168168 |
| 2012年08月14日 02:02:30 | r.david.murray | set | nosy:
+ r.david.murray messages: + msg168165 |
| 2012年08月14日 01:02:20 | chris.jerdonek | set | files:
+ issue-15543-3.patch nosy: + asvetlov messages: + msg168162 |
| 2012年08月07日 00:43:56 | chris.jerdonek | set | files:
+ issue-15543-2.patch messages: + msg167592 |
| 2012年08月06日 03:44:04 | chris.jerdonek | set | files:
+ issue-15543-1.patch keywords: + patch messages: + msg167534 stage: patch review |
| 2012年08月04日 02:21:08 | chris.jerdonek | set | messages: + msg167393 |
| 2012年08月04日 00:44:33 | pitrou | set | messages: + msg167390 |
| 2012年08月03日 23:33:08 | chris.jerdonek | set | messages: + msg167380 |
| 2012年08月03日 23:12:54 | pitrou | set | messages: + msg167377 |
| 2012年08月03日 23:10:04 | chris.jerdonek | set | nosy:
+ pitrou messages: + msg167376 |
| 2012年08月03日 08:33:24 | chris.jerdonek | set | messages: + msg167298 |
| 2012年08月03日 07:42:08 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka messages: + msg167294 |
| 2012年08月03日 00:20:33 | chris.jerdonek | create | |