This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2012年07月24日 16:32 by eli.bendersky, last changed 2022年04月11日 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| 15442.patch | moijes12, 2012年08月23日 17:29 | I've made the changes toDoc/library/filecmp.rst, Lib/filecmp.py. This is my first patch to python.I don't know how to compile python without having to install it but I'd sure like if someone showed me how to. I'd like to finish this and learn. | review | |
| eli_issue15442.1.patch | eli.bendersky, 2013年01月10日 14:59 | review | ||
| Messages (14) | |||
|---|---|---|---|
| msg166306 - (view) | Author: Eli Bendersky (eli.bendersky) * (Python committer) | Date: 2012年07月24日 16:32 | |
The default ignore list of filecmp.dircmp is ['RCS', 'CVS', 'tags']. This predates even Subversion! I suggest to freshen up this module to also ignore the dirs for SVN, Mercurial, Git and Bazaar. [this is a new feature, so no earlier than 3.4...] |
|||
| msg168962 - (view) | Author: Chris Jerdonek (chris.jerdonek) * (Python committer) | Date: 2012年08月23日 19:47 | |
Hi moijes12, for instructions on compiling and submitting patches, etc., see the Python Developer's Guide (aka the devguide). You may also be interested in the Python Mentors Group: http://pythonmentors.com/ Lastly (a small point), in the future you can also type comments about your patch in the "Comment" text field in addition to the "File Description" text field. You can do this in the same "Submit Changes" operation that you use to choose and upload your file. |
|||
| msg169024 - (view) | Author: R. David Murray (r.david.murray) * (Python committer) | Date: 2012年08月24日 14:34 | |
moijes12, thanks for the patch. Since this is a new feature we'll need to wait until the 3.3 RC1 repo is branched before applying it. |
|||
| msg172882 - (view) | Author: Eli Bendersky (eli.bendersky) * (Python committer) | Date: 2012年10月14日 13:39 | |
moijes12, why are the added names "raw" ? |
|||
| msg172920 - (view) | Author: Éric Araujo (eric.araujo) * (Python committer) | Date: 2012年10月14日 20:49 | |
ISTM the names should be regular names, not regular expression patterns. |
|||
| msg172964 - (view) | Author: Eli Bendersky (eli.bendersky) * (Python committer) | Date: 2012年10月15日 12:29 | |
I tend to agree with Éric here. moijes12, would you like to send an updated patch without the raw literals, and with added tests for the new/changed functionality? |
|||
| msg172986 - (view) | Author: moijes12 (moijes12) | Date: 2012年10月15日 16:52 | |
Yeah. I'm on it. |
|||
| msg172992 - (view) | Author: Serhiy Storchaka (serhiy.storchaka) * (Python committer) | Date: 2012年10月15日 17:44 | |
Should __pycache__ be ignored too? |
|||
| msg179338 - (view) | Author: Éric Araujo (eric.araujo) * (Python committer) | Date: 2013年01月08日 11:41 | |
> Should __pycache__ be ignored too? Sounds good. > I don't know how to compile python without having to install it See the devguide http://docs.python.org/devguide |
|||
| msg179554 - (view) | Author: Eli Bendersky (eli.bendersky) * (Python committer) | Date: 2013年01月10日 14:59 | |
Attaching an alternative patch, that goes one (little) step further. Instead of repeating the ignored list all over the place (code, docstrings, ReST docs), the module exposes DEFAULT_IGNORES so everything can refer to it. Also added some tests for this feature. The patch is only vs. default (3.4), of course. |
|||
| msg179796 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2013年01月12日 14:13 | |
New changeset a1efab48d8f8 by Eli Bendersky in branch 'default': Close #15442: Expand the list of default directories ignored by filecmp.dircmp and expose it as a module attribute http://hg.python.org/cpython/rev/a1efab48d8f8 |
|||
| msg179825 - (view) | Author: Éric Araujo (eric.araujo) * (Python committer) | Date: 2013年01月12日 17:59 | |
+ .. versionadded:: 3.3 3.4* |
|||
| msg179834 - (view) | Author: Eli Bendersky (eli.bendersky) * (Python committer) | Date: 2013年01月12日 22:03 | |
What? Where did you see 3.3? It says 3.4 ;-) Thanks, fixed in 72ddb250f058 |
|||
| msg213098 - (view) | Author: Roundup Robot (python-dev) (Python triager) | Date: 2014年03月10日 22:11 | |
New changeset 2b1d5caf63ca by R David Murray in branch 'default': whatsnew: filecmp.DEFAULT_IGNORES (#15442) http://hg.python.org/cpython/rev/2b1d5caf63ca |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:33 | admin | set | github: 59647 |
| 2014年03月10日 22:11:22 | python-dev | set | messages: + msg213098 |
| 2013年01月12日 22:03:48 | eli.bendersky | set | messages: + msg179834 |
| 2013年01月12日 17:59:43 | eric.araujo | set | messages: + msg179825 |
| 2013年01月12日 14:13:56 | python-dev | set | status: open -> closed nosy: + python-dev messages: + msg179796 resolution: fixed stage: test needed -> resolved |
| 2013年01月10日 14:59:51 | eli.bendersky | set | files:
+ eli_issue15442.1.patch messages: + msg179554 |
| 2013年01月08日 11:41:20 | eric.araujo | set | messages:
+ msg179338 stage: needs patch -> test needed |
| 2013年01月08日 07:20:56 | ezio.melotti | set | nosy:
+ ezio.melotti |
| 2013年01月07日 17:40:30 | serhiy.storchaka | set | nosy:
- serhiy.storchaka |
| 2012年10月15日 17:44:30 | serhiy.storchaka | set | nosy:
+ serhiy.storchaka messages: + msg172992 |
| 2012年10月15日 16:52:37 | moijes12 | set | messages: + msg172986 |
| 2012年10月15日 12:29:50 | eli.bendersky | set | messages: + msg172964 |
| 2012年10月14日 20:49:01 | eric.araujo | set | nosy:
+ eric.araujo messages: + msg172920 |
| 2012年10月14日 13:39:14 | eli.bendersky | set | messages: + msg172882 |
| 2012年08月24日 14:34:22 | r.david.murray | set | nosy:
+ r.david.murray messages: + msg169024 |
| 2012年08月23日 19:47:01 | chris.jerdonek | set | nosy:
+ chris.jerdonek messages: + msg168962 |
| 2012年08月23日 17:29:06 | moijes12 | set | files:
+ 15442.patch keywords: + patch |
| 2012年08月23日 14:42:55 | moijes12 | set | nosy:
+ moijes12 |
| 2012年07月24日 16:32:11 | eli.bendersky | create | |