This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2012年05月30日 23:08 by Ronny.Pfannschmidt, last changed 2022年04月11日 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| resolve_name.patch | Ronny.Pfannschmidt, 2012年05月30日 23:08 | |||
| resolve_name.patch | Ronny.Pfannschmidt, 2012年05月31日 12:32 | |||
| resolve_name.patch | Ronny.Pfannschmidt, 2012年05月31日 12:49 | |||
| Messages (6) | |||
|---|---|---|---|
| msg161974 - (view) | Author: Ronny Pfannschmidt (Ronny.Pfannschmidt) | Date: 2012年05月30日 23:08 | |
this patch simplifies and cleans up the resolve_name function |
|||
| msg161975 - (view) | Author: Éric Araujo (eric.araujo) * (Python committer) | Date: 2012年05月30日 23:42 | |
Thanks! I would love to get your review on #12703 (not sure if this bug is a duplicate or an unrelated cleanup). |
|||
| msg161989 - (view) | Author: Ronny Pfannschmidt (Ronny.Pfannschmidt) | Date: 2012年05月31日 11:15 | |
my change is a unrelated cleanup but the ideas in the patch look good the attribute error addition seems relevant i'll adapt my patch to raise the original import error for toplevel import failure and accumuplate the attrbute name so it can raise the correct error |
|||
| msg161995 - (view) | Author: Ronny Pfannschmidt (Ronny.Pfannschmidt) | Date: 2012年05月31日 12:32 | |
updated the patch with more detailed errors |
|||
| msg161997 - (view) | Author: Ronny Pfannschmidt (Ronny.Pfannschmidt) | Date: 2012年05月31日 12:49 | |
i missused hg export, here is a corrected patch |
|||
| msg164565 - (view) | Author: Éric Araujo (eric.araujo) * (Python committer) | Date: 2012年07月03日 04:33 | |
Closing as duplicate. I have new tests for resolve_name (need to port them from p7g to d2 and upload a patch); if your patch makes them pass or if it can be merged with another patch that fixes the function, it’s easier to have all on one issue; if your patch makes the code more readable without fixing it then I think another patch will go in. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:31 | admin | set | github: 59169 |
| 2014年03月13日 04:21:32 | eric.araujo | set | status: open -> closed resolution: out of date stage: patch review -> resolved |
| 2012年07月03日 04:35:21 | eric.araujo | set | files: + resolve_name.patch |
| 2012年07月03日 04:33:59 | eric.araujo | set | files: - resolve_name.patch |
| 2012年07月03日 04:33:14 | eric.araujo | set | messages: + msg164565 |
| 2012年05月31日 12:49:54 | Ronny.Pfannschmidt | set | files:
+ resolve_name.patch messages: + msg161997 |
| 2012年05月31日 12:32:33 | Ronny.Pfannschmidt | set | files:
+ resolve_name.patch messages: + msg161995 |
| 2012年05月31日 11:15:39 | Ronny.Pfannschmidt | set | messages: + msg161989 |
| 2012年05月30日 23:42:40 | eric.araujo | set | stage: patch review messages: + msg161975 versions: + 3rd party, Python 3.3 |
| 2012年05月30日 23:08:33 | Ronny.Pfannschmidt | create | |