homepage

In Tools/abitype.py an exception is raised using the old format:
raise Exception, '%s has no PyVarObject_HEAD_INIT' % name
The attached patch fixes this problem.

Thanks for the patch.
Do you have an interest in trying your hand at writing a test for this to go into Lib/test/test_tools.py?

Nevermind, it occurred to me that what we really need is a 'test_sundry' style test for the tools. Here's a patch that adds that. I'll apply it after I fix the other bugs it reveals (which include the other two you pointed out as a subset...).

Oh, ok then. That makes the last file added in 14491 irrelevant.

Hmm. I came across this error yesterday in the tests, when broke utf-16 decoder. The error was introduced in the module atexit. Until it all tests passed successfully, and this branch will not run.
A simple search
find -name '*.py' -exec egrep '\braise +\w+[^(]*,' '{}' +
showed more than a thousand of problem lines.

Serhiy: I'm not sure what you are talking about. Does it relate to this specific issue (abitype.py)?

Fixed in 62dde5dd475e and 696cb524322a. Thanks for the patch.

Serhiy is talking about the same syntax issue, but in other files, such as Tools/msi. The regex given sprouts a lot of false positives from comments or docstrings; for the msi one, I presume it is not a bug (it’s probably run with Python 2), otherwise Martin would have noticed it when making releases.

Because of some error in my source tree was a lot of Python2 files, which gave a false result (see issue 14497). After cleaning, old-style raise was only in Mac/BuildScript/build-installer.py and Tools/msi/.