This issue tracker has been migrated to GitHub ,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2012年03月13日 22:12 by Brian.Jones, last changed 2022年04月11日 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| msg_api_subclass_bug_test.patch | Brian.Jones, 2012年03月13日 22:12 | Adds a unit test to trigger brokenness in how super() is being used to call parent-delegated methods. | ||
| Messages (3) | |||
|---|---|---|---|
| msg155679 - (view) | Author: Brian Jones (Brian.Jones) * | Date: 2012年03月13日 22:12 | |
In email6, the message.Message class tries to delegate calls to methods not defined in Message to message._HeaderList. However, delegating in this way makes the methods inaccessible when accessing them through a call to super(). This comes into play in the http.HTTPMessage class, which attempts to call the _HeaderList 'get' method as 'super().get()'. An AttributeError is raised in this case, because super is only examining the class, and not the instance, and isn't executing __getattr__ to get at methods defined in _HeaderList methods. I've attached a patch that only patches the appropriate test module to add a test to prove the failure. The fix involves a bit more complexity, and I've had some trouble getting my brain to not reject the kind of conflation of concepts and overlapping of responsibility that needs to take place to implement the ideas I was able to come up with. I'm happy to help implement a sane solution if anyone has other ideas. A couple of ideas that came up (at the PyCon sprints) were: 1. Make _HeaderList *not* extend 'list', and then have Message inherit from _HeaderList. However, that means basically reimplementing all of the methods in the 'list' interface inside of _HeaderList, and by extension, Message becomes something of a 'list' object for the purpose of header manipulation, but not for anything else (like, say, payload). 2. Just get rid of _HeaderList and put it all inside of Message. See item 1 for issues with this idea. 3. Expose a public 'headers' attribute, which opens a lot of doors in terms of design flexibility, elegance, and cleanliness, but changes the API. 4. Create a base class that defines the non-list-specific interface for _HeaderList. _HeaderList would then inherit from this class, adding the list-specific methods on top, and Message would inherit it and only override non-list-specific methods. This could have some benefits in terms of testing, but arguably it muddies the waters for those maintaining/extending the _HeaderList or Message code. Other ideas? Also let me know if I've done something silly in writing the test to trigger the problem. |
|||
| msg222186 - (view) | Author: Mark Lawrence (BreamoreBoy) * | Date: 2014年07月03日 14:26 | |
@David I believe this is one for your TODO list. |
|||
| msg227179 - (view) | Author: R. David Murray (r.david.murray) * (Python committer) | Date: 2014年09月20日 21:29 | |
_Headerlist never made it into the committed code. Subclassing Message works fine in both the mainline email code and the provisional extensions. |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022年04月11日 14:57:27 | admin | set | github: 58501 |
| 2014年09月20日 21:29:37 | r.david.murray | set | status: open -> closed resolution: out of date messages: + msg227179 stage: resolved |
| 2014年07月03日 14:26:10 | BreamoreBoy | set | versions:
+ Python 3.4, Python 3.5, - Python 3.3 nosy: + barry, BreamoreBoy messages: + msg222186 components: + email, - Library (Lib) type: behavior |
| 2012年03月13日 22:12:52 | Brian.Jones | create | |