homepage

The arraymodule depends on "structmember.h". Patch attached.

There is a comment in setup.py that suggests that *all* Python headers
should be added to the dependencies (?):
 # Python header files
 headers = [sysconfig.get_config_h_filename()]
 headers += glob(os.path.join(sysconfig.get_path('platinclude'), "*.h"))
Was that the intention? Because this is what I get when I add a
print statement:
['/home/stefan/pydev/cpython/pyconfig.h', '/home/stefan/pydev/cpython/pyconfig.h']

In Python2.6 all headers from Include/ were added:
 # Python header files
 headers = glob("Include/*.h") + ["pyconfig.h"]

Does the 2.6 code work when you build in a subdirectory? (I assume that’s why sysconfig is used instead of hard-coding, but I’ll check the VCS log when I have some time to be sure.)

I actually meant: when you build in any directory other that the top-level checkout directory.

Dependency support added: 1be93dd179df
Last good version (all Include/*.h): 9705ef3fdb22
Current behavior (only pyconfig.h): fa69e891edf4
To answer your question: Neither of the last two revisions builds
in an out-of-source directory.
Raising the priority to high: The missing dependencies caused a
bug report on core-mentorship that was extremely time consuming
until I finally had the revelation that the submitter did not
run `make distclean` after `hg fetch` (which would not be necessary
with the dependencies in place).

Here's a patch.

> To answer your question: Neither of the last two revisions builds
> in an out-of-source directory.
My question was more whether the last known good revision did :)
> Here's a patch.
Tested with Python built in the top-level dir and in another dir, works in both cases. Please apply, but not to security-only branches.

New changeset 1c77eadba9dc by Stefan Krah in branch '3.2':
Issue #14152: Restore the Include/*.h dependencies for extension builds.
http://hg.python.org/cpython/rev/1c77eadba9dc
New changeset c85812b0e97d by Stefan Krah in branch 'default':
Issue #14152: Merge fix from 3.2.
http://hg.python.org/cpython/rev/c85812b0e97d
New changeset 3e2c230f4664 by Stefan Krah in branch '2.7':
Issue #14152: backport fix.
http://hg.python.org/cpython/rev/3e2c230f4664 

??ric Araujo <report@bugs.python.org> wrote:
> > To answer your question: Neither of the last two revisions builds
> > in an out-of-source directory.
> My question was more whether the last known good revision did :)
That's what I meant. "last two revisions" was intended to refer to
the last two entries in the list. But I see the ambiguity. :)
Thanks for reviewing!