homepage

Issue #14113 pointed out that test.support doesn't check if tests mucked with the locale after running.

Here's a test that checks for changes to the locale.

Thanks for the patch, but I think Brett meant to say that this should be added to Lib/test/regrtest.py:750, among the other resources.

Patch to check if locale was changed.
Since I'm not sure where to put tests for test.regrtest, I created 
new file, test.test_regrtest.

New changeset 4fcd50a6dca7 by Brett Cannon in branch 'default':
Issue #14135: Make sure tests don't leave the locale changed for any
http://hg.python.org/cpython/rev/4fcd50a6dca7 

Sorry it took so wrong to get to this. It simply fell out of my purview.

I had to back out this changeset as it totally broke the test suite here:
[ 91/372/90] test_defaultdict
test test_defaultdict crashed -- Traceback (most recent call last):
 File "/home/antoine/cpython/default/Lib/test/regrtest.py", line 1287, in runtest_inner
 with saved_test_environment(test, verbose, quiet) as environment:
 File "/home/antoine/cpython/default/Lib/test/regrtest.py", line 1251, in __enter__
 in self.resource_info())
 File "/home/antoine/cpython/default/Lib/test/regrtest.py", line 1250, in <genexpr>
 self.saved_values = dict((name, get()) for name, get, restore
 File "/home/antoine/cpython/default/Lib/test/regrtest.py", line 1237, in get_locale
 return tuple(map(locale.getlocale, self._locale_categories))
 File "/home/antoine/cpython/default/Lib/locale.py", line 523, in getlocale
 raise TypeError('category LC_ALL is not supported')
TypeError: category LC_ALL is not supported
(etc.)

Can you check the attached patch works for you, Antoine?

It does, thank you.

New changeset dfe04eaa3924 by Brett Cannon in branch 'default':
Issue #14135: Let's try this again.
http://hg.python.org/cpython/rev/dfe04eaa3924