homepage

multiprocessing.Condition is missing a counterpart for the wait_for() method added to threading.Condition in Python 3.2.
I will work on a patch.

Patch which just copies the implementation from threading.

In test/test_multiprocessing.py:
"""
 def test_waitfor(self):
 [...]
 with cond:
 result = cond.wait_for(lambda : state.value==0)
 self.assertTrue(result)
 self.assertEqual(state.value, 0)
 for i in range(4):
 time.sleep(0.01)
 with cond:
 state.value += 1
 cond.notify()
"""
Shouldn't the `for` loop be outside the outer `with` block?
In Lib/multiprocessing/managers.py:
Is there a good reason why the wait_for() proxy method can't simply be implemented as:
return self._callmethod('wait_for', (predicate, timeout))?
(There may be, I just didn't check).
Finally, the documentation should be updated (Doc/library/multiprocessing.rst).
Otherwise, it would probably be better if you could submit a contributor agreement (and also maybe update your name on the tracker), unless that's a problem for you?

> Shouldn't the `for` loop be outside the outer `with` block?
Yes.
> In Lib/multiprocessing/managers.py:
> Is there a good reason why the wait_for() proxy method can't simply be
> implemented as:
> return self._callmethod('wait_for', (predicate, timeout))?
> 
> (There may be, I just didn't check).
That would only work if predicate is picklable, which is unlikely to be the case. (The lambda functions used in the unit tests are not picklable.)
> Finally, the documentation should be updated 
> (Doc/library/multiprocessing.rst).
Fixed in new patch.
> Otherwise, it would probably be better if you could submit a contributor 
> agreement (and also maybe update your name on the tracker), unless that's
> a problem for you?
I will try to submit it over the weekend.

AFAICT (Raw)Value relies on ctypes, so the tests should be skipped if ctypes is unavailable. Or I guess you could use a Semaphore instead.

New patch skips tests if ctypes not available.

New patch which calculates endtime outside loop.

Charles-François, will you take this one? :)

> Charles-François, will you take this one? :)
Yes :-)

New changeset 5606ee052783 by Charles-François Natali in branch 'default':
Issue #14087: multiprocessing: add Condition.wait_for(). Patch by sbt.
http://hg.python.org/cpython/rev/5606ee052783 

Committed.
Thanks for the patch, and sorry for the delay!